8000 update to official maven wrapper by denis-yuen · Pull Request #4959 · dockstore/dockstore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update to official maven wrapper #4959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2022
Merged

update to official maven wrapper #4959

merged 3 commits into from
Jun 23, 2022

Conversation

denis-yuen
Copy link
Member

Description
Not very exciting. Turns out big version jump is because mvnw is now officially part of maven
https://lists.apache.org/thread/8wxdxxpzhcylrmsqzfb8fdwbcwy3w970
https://github.com/takari/maven-wrapper/blob/master/CHANGELOG.md

Probably still worth doing because there's better documentation now https://maven.apache.org/wrapper/

Issue
https://ucsc-cgl.atlassian.net/browse/DOCK-2079

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future

@denis-yuen denis-yuen self-assigned this Jun 17, 2022
@denis-yuen denis-yuen mentioned this pull request Jun 17, 2022
Merged
1 task
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link
codecov bot commented Jun 22, 2022 •
edited
Loading

Codecov Report

Merging #4959 (4792496) into develop (33ce364) will increase coverage by 4.03%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4959      +/-   ##
=============================================
+ Coverage      69.02%   73.05%   +4.03%     
- Complexity      3988     4231     +243     
=============================================
  Files            285      285              
  Lines          16421    16421              
  Branches        1815     1815              
=============================================
+ Hits           11334    11997     +663     
+ Misses          4199     3576     -623     
+ Partials         888      848      -40
Flag Coverage Δ
bitbuckettests 26.46% <ø> (?)
integrationtests 58.12% <ø> (ø)
languageparsingtests 8.42% <ø> (?)
toolintegrationtests 31.23% <ø> (?)
unit-tests_and_non-confidential-tests 25.79% <ø> (ø)
workflowintegrationtests 40.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/java/io/dockstore/webservice/jdbi/EntryDAO.java 88.46% <0.00%> (+0.64%) ⬆️
...store/webservice/helpers/GitHubSourceCodeRepo.java 72.97% <0.00%> (+1.18%) ⬆️
.../io/dockstore/webservice/languages/CWLHandler.java 70.27% <0.00%> (+1.22%) ⬆️
...java/io/dockstore/webservice/jdbi/WorkflowDAO.java 71.17% <0.00%> (+1.80%) ⬆️
.../main/java/io/dockstore/webservice/core/Entry.java 91.81% <0.00%> (+2.33%) ⬆️
...ain/java/io/dockstore/webservice/jdbi/ToolDAO.java 85.50% <0.00%> (+2.89%) ⬆️
...n/src/main/java/io/dockstore/common/Utilities.java 68.25% <0.00%> (+3.17%) ⬆️
...tore/webservice/core/dockerhub/DockerHubImage.java 28.57% <0.00%> (+3.57%) ⬆️
...tore/webservice/helpers/SourceCodeRepoFactory.java 77.63% <0.00%> (+5.26%) ⬆️
...c/main/java/io/dockstore/webservice/core/Tool.java 88.46% <0.00%> (+5.76%) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ce364...4792496. Read the comment docs.

@denis-yuen denis-yuen marked this pull request as ready for review June 22, 2022 15:08
@denis-yuen denis-yuen merged commit a99ec36 into develop Jun 23, 2022
@denis-yuen denis-yuen deleted the feature/mvn_wrapper_update branch June 23, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coverbeck coverbeck coverbeck approved these changes

@wshands wshands wshands approved these changes

@svonworl svonworl svonworl approved these changes

@amarjandu amarjandu Awaiting requested review from amarjandu

Assignees

@denis-yuen denis-yuen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denis-yuen @coverbeck @wshands @svonworl
0