fix cron build #247
Merged
fix cron build #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Snyk warning seems like a false positive, where we haven't upgraded to junit 5, we're using 4.13.2 (past the recommended version) |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #247 +/- ##
==============================================
+ Coverage 47.06% 69.49% +22.42%
+ Complexity 1463 1039 -424
==============================================
Files 94 47 -47
Lines 12142 6071 -6071
Branches 1598 799 -799
==============================================
- Hits 5715 4219 -1496
+ Misses 5832 1513 -4319
+ Partials 595 339 -256
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
svonworl
approved these changes
Jun 22, 2023
kathy-t
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Side-effect of linked PR, need to upgrade cwlavro to avoid nightly cron builds from failing
Review Instructions
Check and see if the nightly CLI cron build passes
Issue
dockstore/dockstore#5564
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
./mvnw clean install