cwlavro update #5564
Merged
cwlavro update #5564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #5564 +/- ##
=============================================
- Coverage 73.98% 72.09% -1.89%
+ Complexity 4979 4868 -111
=============================================
Files 342 342
Lines 18329 18329
Branches 1970 1970
=============================================
- Hits 13560 13214 -346
- Misses 3832 4152 +320
- Partials 937 963 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
svonworl
approved these changes
Jun 20, 2023
david4096
approved these changes
Jun 20, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gets us close to turning on transitive dependency ban to enforce old dependencies even from transitive dependencies.
The last dependency is just the swagger-core 1.6.8 dependency
i.e. once we turn off swagger 2.0 and fully transition to openapi 3.0, we may be able to turn on the check assuming no other transitives are brought in
Review Instructions
n/a should build and function as before, just with a more consistent classpath
Issue
n/a
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install@RolesAllowedannotation