Remove aggregation of aggregated executions #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #487 +/- ##
=============================================
- Coverage 57.10% 56.41% -0.70%
+ Complexity 304 295 -9
=============================================
Files 32 32
Lines 1991 1964 -27
Branches 167 166 -1
=============================================
- Hits 1137 1108 -29
+ Misses 780 779 -1
- Partials 74 77 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kathy-t
commented
Feb 26, 2024
pom.xml
Outdated
| <changelist>.0-SNAPSHOT</changelist> | ||
|
|
||
| <github.url>scm:git:git@github.com:dockstore/dockstore-support.git</github.url> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <dockstore-core.version>1.15.0-rc.2</dockstore-core.version> | ||
| <dockstore-core.version>1.16.0-SNAPSHOT</dockstore-core.version> |
There was a problem hiding this comment.
Will update to a tag when dockstore/dockstore#5824 is merged
9 tasks
denis-yuen
approved these changes
Feb 26, 2024
svonworl
approved these changes
Feb 27, 2024
coverbeck
approved these changes
Feb 27, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corresponding PR: dockstore/dockstore#5824
This PR modifies the metrics aggregator so that it doesn't aggregate aggregated executions, which is entirely removed from the webservice.
Review Instructions
See instructions in dockstore/dockstore#5824
Issue
SEAB-6246
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean installin the project that you have modified (until https://ucsc-cgl.atlassian.net/browse/SEAB-5300 adds multi-module support properly)