8000 Remove deprecated aggregated executions field by kathy-t · Pull Request #5824 · dockstore/dockstore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove deprecated aggregated executions field #5824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2024
Merged

Remove deprecated aggregated executions field #5824

merged 2 commits into from
Feb 28, 2024

Conversation

kathy-t
Copy link
Contributor
@kathy-t kathy-t commented Feb 26, 2024 •
edited
Loading

Description
Corresponding PR: dockstore/dockstore-support#487

This PR removes the deprecated aggregated executions field from ExecutionsRequestBody, removing the ability for users to submit aggregated metrics.

Review Instructions
Verify that the request body schema for this endpoint does not have the aggregatedExecutions field.

Issue
SEAB-6246

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here.
No concerns

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@kathy-t kathy-t self-assigned this Feb 26, 2024
@codecov Codecov
Copy link
codecov bot commented Feb 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.37%. Comparing base (19c99aa) to head (75c2cc9).
Report is 4 commits behind head on develop.

Files Patch % Lines
...s/constraints/HasExecutionsOrMetricsValidator.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #5824      +/-   ##
=============================================
- Coverage      74.41%   74.37%   -0.04%     
+ Complexity      5267     5254      -13     
=============================================
  Files            365      364       -1     
  Lines          19042    19022      -20     
  Branches        2021     2019       -2     
=============================================
- Hits           14170    14148      -22     
- Misses          3915     3917       +2     
  Partials         957      957
Flag Coverage Δ
bitbuckettests 27.06% <0.00%> (+0.01%) ⬆️
integrationtests 58.31% <0.00%> (+0.05%) ⬆️
languageparsingtests 10.85% <0.00%> (+0.01%) ⬆️
localstacktests 21.39% <66.66%> (-0.09%) ⬇️
toolintegrationtests 30.41% <0.00%> (+0.03%) ⬆️
unit-tests_and_non-confidential-tests 28.75% <0.00%> (+0.03%) ⬆️
workflowintegrationtests 38.68% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kathy-t kathy-t mentioned this pull request Feb 26, 2024
Merged
4 tasks
denis-yuen
denis-yuen approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member
@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
btw security section (although there should be no changes here, if anything an improvement since there is less to maintain)

Maybe there should be a checklist box to draw the eye

@denis-yuen denis-yuen mentioned this pull request Feb 27, 2024
Merged
9 tasks
@kathy-t kathy-t merged commit 1e7da37 into develop Feb 28, 2024
@kathy-t kathy-t deleted the feature/seab-6246/remove-aggregated-executions branch February 28, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coverbeck coverbeck coverbeck approved these changes

@denis-yuen denis-yuen denis-yuen approved these changes

@svonworl svonworl svonworl approved these changes

@hyunnaye hyunnaye Awaiting requested review from hyunnaye

Assignees

@kathy-t kathy-t

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kathy-t @coverbeck @denis-yuen @svonworl
0