8000 DOCK-2571: Cherry pick "improve relative readMePath error message" to hotfix branch by svonworl · Pull Request #6041 · dockstore/dockstore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

DOCK-2571: Cherry pick "improve relative readMePath error message" to hotfix branch #6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2024
Merged

DOCK-2571: Cherry pick "improve relative readMePath error message" to hotfix branch #6041

merged 1 commit into from
Dec 2, 2024

Conversation

svonworl
Copy link
Contributor
@svonworl svonworl commented Nov 22, 2024 •
edited
Loading

Description
Woops, I accidentally merged the original PR to develop. This PR cherrypicks it to the hotfix branch, so that we make the change where it was originally intended.

Review Instructions
See https://ucsc-cgl.atlassian.net/browse/DOCK-2571

Issue
https://ucsc-cgl.atlassian.net/browse/DOCK-2571
#5982

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@svonworl svonworl self-assigned this Nov 22, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
40.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link
codecov bot commented Nov 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (57b0aee) to head (ae3d8b2).
Report is 1 commits behind head on hotfix/1.16.1.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##             hotfix/1.16.1    #6041      +/-   ##
===================================================
- Coverage  
8000
          74.56%   74.46%   -0.11%     
+ Complexity            5501     5496       -5     
===================================================
  Files                  381      381              
  Lines                19786    19786              
  Branches              2043     2043              
===================================================
- Hits                 14754    14733      -21     
- Misses                4056     4074      +18     
- Partials               976      979       +3
Flag Coverage Δ
bitbuckettests 26.66% <ø> (-0.12%) ⬇️
hoverflytests 27.95% <ø> (+0.01%) ⬆️
integrationtests 56.71% <ø> (+0.01%) ⬆️
languageparsingtests 11.05% <ø> (ø)
localstacktests 21.57% <ø> (ø)
toolintegrationtests 30.03% <ø> (ø)
unit-tests_and_non-confidential-tests 25.80% <ø> (+0.01%) ⬆️
workflowintegrationtests 38.06% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svonworl svonworl merged commit f62867c into hotfix/1.16.1 Dec 2, 2024
18 of 19 checks passed
@svonworl svonworl deleted the feature/dock-2571/cherrypick-to-hotfix branch December 2, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coverbeck coverbeck coverbeck approved these changes

@denis-yuen denis-yuen denis-yuen approved these changes

@kathy-t kathy-t kathy-t approved these changes

@hyunnaye hyunnaye Awaiting requested review from hyunnaye

@david4096 david4096 Awaiting requested review from david4096

Assignees

@svonworl svonworl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@svonworl @coverbeck @denis-yuen @kathy-t
0