Add rule to add HasFactory to Models #353
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9e9e508 to
09ebd2d
Compare
f56970d to
b54dc0a
Compare
The set is not really complete without it. It'll work if you use the factory directly, but the other rectors convert to use the static method which this rector fixes
|
Sorry @jradtilbrook things have been a bit busy lately. It looks overall good, I need to consider adding to the rule group and just the structure of the tests |
|
@jradtilbrook would you be able to refactor your branch to structure your tests like you did in the other branch? #351 |
|
👍 I'll try get onto that tonight |
|
@peterfox ready to go now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new rule that adds the
HasFactorytrait to Eloquent models if not present. Useful as part of the other factory related rules to upgrade pre-v8.0 code.I think might be worth including this in the set and updating some docs - let me know 👍