driftingly · jradtilbrook · Jun 20, 2025 · Jun 20, 2025 · Jun 20, 2025 · Jun 20, 2025
diff --git a/config/sets/laravel-legacy-factories-to-classes.php b/config/sets/laravel-legacy-factories-to-classes.php
@@ -3,6 +3,7 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
+use RectorLaravel\Rector\Class_\AddHasFactoryToModelsRector;
 use RectorLaravel\Rector\FuncCall\FactoryFuncCallToStaticCallRector;
 use RectorLaravel\Rector\MethodCall\FactoryApplyingStatesRector;
 use RectorLaravel\Rector\Namespace_\FactoryDefinitionRector;
@@ -13,6 +14,7 @@
     // https://laravel.com/docs/7.x/database-testing#writing-factories
     // https://laravel.com/docs/8.x/database-testing#defining-model-factories
     $rectorConfig->rule(FactoryDefinitionRector::class);
+    $rectorConfig->rule(AddHasFactoryToModelsRector::class);
 
     // https://laravel.com/docs/7.x/database-testing#using-factories
     // https://laravel.com/docs/8.x/database-testing#creating-models-using-factories

diff --git a/docs/rector_rules_overview.md b/docs/rector_rules_overview.md
@@ -59,6 +59,28 @@ Adds the `@extends` annotation to Factories.
 
 <br>
 
+## AddHasFactoryToModelsRector
+
+Adds the `HasFactory` trait to Models.
+
+:wrench: **configure it!**
+
+- class: [`RectorLaravel\Rector\Class_\AddHasFactoryToModelsRector`](../src/Rector/Class_/AddHasFactoryToModelsRector.php)
+
+```diff
+ namespace App\Models;
+
+ use Illuminate\Database\Eloquent\Factories\Factory;
+ use Illuminate\Database\Eloquent\Model;
+
+ class User extends Model
+ {
++    use \Illuminate\Database\Eloquent\Factories\HasFactory;
+ }
+```
+
+<br>
+
 ## AddGenericReturnTypeToRelationsRector
 
 Add generic return type to relations in child of `Illuminate\Database\Eloquent\Model`

diff --git a/src/Rector/Class_/AddHasFactoryToModelsRector.php b/src/Rector/Class_/AddHasFactoryToModelsRector.php
@@ -0,0 +1,111 @@
+<?php
+
+declare(strict_types=1);
+
+namespace RectorLaravel\Rector\Class_;
+
+use PhpParser\Node;
+use PhpParser\Node\Name\FullyQualified;
+use PhpParser\Node\Stmt\Class_;
+use PhpParser\Node\Stmt\TraitUse;
+use PHPStan\Reflection\ClassReflection;
+use PHPStan\Type\ObjectType;
+use Rector\Contract\Rector\ConfigurableRectorInterface;
+use Rector\Rector\AbstractRector;
+use Rector\Reflection\ReflectionResolver;
+use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+use Webmozart\Assert\Assert;
+
+/**
+ * @changelog https://github.com/laravel/framework/pull/39310
+ *
+ * @see \RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRector\AddHasFactoryToModelsRectorTest
+ * @see \RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRectorConfiguredTest\AddHasFactoryToModelsRectorConfiguredTest
+ */
+final class AddHasFactoryToModelsRector extends AbstractRector implements ConfigurableRectorInterface
+{
+    private const string TRAIT_NAME = 'Illuminate\Database\Eloquent\Factories\HasFactory';
+
+    /**
+     * @var string[]
+     */
+    private array $allowList = [];
+
+    public function __construct(
+        private readonly ReflectionResolver $reflectionResolver,
+    ) {}
+
+    public function getRuleDefinition(): RuleDefinition
+    {
+        return new RuleDefinition('Adds the HasFactory trait to Models.', [
+            new ConfiguredCodeSample(
+                <<<'CODE_SAMPLE'
+use Illuminate\Database\Eloquent\Model;
+
+class User extends Model
+{
+}
+CODE_SAMPLE
+
+                ,
+                <<<'CODE_SAMPLE'
+use Illuminate\Database\Eloquent\Model;
+
+class User extends Model
+{
+    use \Illuminate\Database\Eloquent\Factories\HasFactory;
+}
+CODE_SAMPLE, ['App\Models\User']
+            ),
+        ]);
+    }
+
+    public function configure(array $configuration): void
+    {
+        Assert::allString($configuration);
+        $this->allowList = $configuration;
+    }
+
+    /**
+     * @return array<class-string<Node>>
+     */
+    public function getNodeTypes(): array
+    {
+        return [Class_::class];
+    }
+
+    /**
+     * @param  Class_  $node
+     */
+    public function refactor(Node $node): ?Node
+    {
+        if ($this->shouldSkipClass($node)) {
+            return null;
+        }
+
+        $traitUse = new TraitUse([new FullyQualified(self::TRAIT_NAME)]);
+
+        $node->stmts = array_merge([$traitUse], $node->stmts);
+
+        return $node;
+    }
+
+    private function shouldSkipClass(Class_ $class): bool
+    {
+        if (! $this->isObjectType($class, new ObjectType('Illuminate\Database\Eloquent\Model'))) {
+            return true;
+        }
+
+        if ($this->allowList !== [] && ! $this->isNames($class, $this->allowList)) {
+            return true;
+        }
+
+        $classReflection = $this->reflectionResolver->resolveClassReflection($class);
+        if (! $classReflection instanceof ClassReflection) {
+            return true;
+        }
+
+        return $classReflection->hasTraitUse(self::TRAIT_NAME);
+    }
+}
diff --git a/stubs/Illuminate/Database/Eloquent/Factories/HasFactory.php b/stubs/Illuminate/Database/Eloquent/Factories/HasFactory.php
@@ -0,0 +1,9 @@
+<?php
+
+namespace Illuminate\Database\Eloquent\Factories;
+
+if (trait_exists('Illuminate\Database\Eloquent\Factories\HasFactory')) {
+    return;
+}
+
+trait HasFactory {}
diff --git a/...s/Rector/Class_/AddHasFactoryToModelsRector/AddHasFactoryToModelsRectorConfiguredTest.php b/...s/Rector/Class_/AddHasFactoryToModelsRector/AddHasFactoryToModelsRectorConfiguredTest.php
@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class AddHasFactoryToModelsRectorConfiguredTest extends AbstractRectorTestCase
+{
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture/Configured');
+    }
+
+    /**
+     * @test
+     */
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule_with_configuration.php';
+    }
+}
diff --git a/tests/Rector/Class_/AddHasFactoryToModelsRector/AddHasFactoryToModelsRectorTest.php b/tests/Rector/Class_/AddHasFactoryToModelsRector/AddHasFactoryToModelsRectorTest.php
@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class AddHasFactoryToModelsRectorTest extends AbstractRectorTestCase
+{
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture/WithoutConfiguration');
+    }
+
+    /**
+     * @test
+     */
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule_without_configuration.php';
+    }
+}
diff --git a/tests/Rector/Class_/AddHasFactoryToModelsRector/Fixture/Configured/fixture.php.inc b/tests/Rector/Class_/AddHasFactoryToModelsRector/Fixture/Configured/fixture.php.inc
@@ -0,0 +1,24 @@
+<?php
+
+namespace RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRector\Fixture\Configured;
+
+use Illuminate\Database\Eloquent\Model;
+
+class User extends Model
+{
+}
+
+?>
+-----
+<?php
+
+namespace RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRector\Fixture\Configured;
+
+use Illuminate\Database\Eloquent\Model;
+
+class User extends Model
+{
+    use \Illuminate\Database\Eloquent\Factories\HasFactory;
+}
+
+?>
diff --git a/tests/Rector/Class_/AddHasFactoryToModelsRector/Fixture/Configured/no_match.php.inc b/tests/Rector/Class_/AddHasFactoryToModelsRector/Fixture/Configured/no_match.php.inc
@@ -0,0 +1,7 @@
+<?php
+
+namespace RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRector\Fixture\Configured;
+
+use Illuminate\Database\Eloquent\Model;
+
+class Person extends Model {}
diff --git a/...tor/Class_/AddHasFactoryToModelsRector/Fixture/Configured/skip_if_already_present.php.inc b/...tor/Class_/AddHasFactoryToModelsRector/Fixture/Configured/skip_if_already_present.php.inc
@@ -0,0 +1,12 @@
+<?php
+
+namespace RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRector\Fixture\Configured;
+
+use Illuminate\Database\Eloquent\Model;
+
+class SkipIfAlreadyPresent extends Model
+{
+    use \Illuminate\Database\Eloquent\Factories\HasFactory;
+}
+
+?>
diff --git a/tests/Rector/Class_/AddHasFactoryToModelsRector/Fixture/WithoutConfiguration/fixture.php.inc b/tests/Rector/Class_/AddHasFactoryToModelsRector/Fixture/WithoutConfiguration/fixture.php.inc
@@ -0,0 +1,24 @@
+<?php
+
+namespace RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRector\Fixture\WithoutConfiguration;
+
+use Illuminate\Database\Eloquent\Model;
+
+class User extends Model
+{
+}
+
+?>
+-----
+<?php
+
+namespace RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRector\Fixture\WithoutConfiguration;
+
+use Illuminate\Database\Eloquent\Model;
+
+class User extends Model
+{
+    use \Illuminate\Database\Eloquent\Factories\HasFactory;
+}
+
+?>
diff --git a/.../AddHasFactoryToModelsRector/Fixture/WithoutConfiguration/skip_if_already_present.php.inc b/.../AddHasFactoryToModelsRector/Fixture/WithoutConfiguration/skip_if_already_present.php.inc
@@ -0,0 +1,12 @@
+<?php
+
+namespace RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRector\Fixture\WithoutConfiguration;
+
+use Illuminate\Database\Eloquent\Model;
+
+class SkipIfAlreadyPresent extends Model
+{
+    use \Illuminate\Database\Eloquent\Factories\HasFactory;
+}
+
+?>
diff --git a/...s/Rector/Class_/AddHasFactoryToModelsRector/config/configured_rule_with_configuration.php b/...s/Rector/Class_/AddHasFactoryToModelsRector/config/configured_rule_with_configuration.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use RectorLaravel\Rector\Class_\AddHasFactoryToModelsRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->import(__DIR__ . '/../../../../../config/config.php');
+
+    $rectorConfig->ruleWithConfiguration(AddHasFactoryToModelsRector::class, [
+        'RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRector\Fixture\Configured\User',
+        'RectorLaravel\Tests\Rector\Class_\AddHasFactoryToModelsRectorConfigured\Fixture\SkipIfAlreadyPresent',
+    ]);
+};
diff --git a/...ector/Class_/AddHasFactoryToModelsRector/config/configured_rule_without_configuration.php b/...ector/Class_/AddHasFactoryToModelsRector/config/configured_rule_without_configuration.php
@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use RectorLaravel\Rector\Class_\AddHasFactoryToModelsRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->import(__DIR__ . '/../../../../../config/config.php');
+
+    $rectorConfig->rule(AddHasFactoryToModelsRector::class);
+};