8000 🔧 fix: Add missing EVM module entrypoint and logger stub by roninjin10 · Pull Request #1756 · evmts/tevm-monorepo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🔧 fix: Add missing EVM module entrypoint and logger stub #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2025
Merged

🔧 fix: Add missing EVM module entrypoint and logger stub #1756

merged 2 commits into from
Jun 1, 2025

Conversation

roninjin10
Copy link
Collaborator
@roninjin10 roninjin10 commented Jun 1, 2025 •
edited
Loading

Description

Added initial EVM module structure with a stub logger implementation. The PR introduces:

  1. EvmLogger.zig with basic logging functionality (debug, info, warn) and scoped logging
  2. evm.zig as the main entry point that imports and exposes all EVM-related modules
  3. Removed an unused logo asset from the UI assets list

Testing

The code includes a test block in evm.zig that will recursively test all declarations in the module. The logger implementation is currently stubbed with TODOs for future implementation.

Additional Information

Your ENS/address:

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Jun 1, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: fcf4104

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link
vercel bot commented Jun 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tevm-monorepo-app ✅ Ready (Inspect) Visit Preview Jun 1, 2025 9:43pm
2 Skipped Deployments
Name Status Preview Updated (UTC)
tevm-monorepo-tevm ⬜️ Ignored (Inspect) Jun 1, 2025 9:43pm
node ⬜️ Skipped (Inspect) Jun 1, 2025 9:43pm

@vercel vercel bot temporarily deployed to Preview – node June 1, 2025 18:39 Inactive
@roninjin10 roninjin10 mentioned this pull request Jun 1, 2025
Merged
1 task
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jun 1, 2025 •
edited
Loading

Warning

Rate limit exceeded

@roninjin10 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 30 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 56e03b4 and fcf4104.

📒 Files selected for processing (2)
  • src/evm/evm.zig (1 hunks)
  • src/ui/assets.zig (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

This was referenced Jun 1, 2025
Merged
Merged
Merged
@roninjin10 Graphite App
Copy link
Collaborator Author
roninjin10 commented Jun 1, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jun 1, 2025
Merged
Merged
This was referenced Jun 1, 2025
Merged
Merged
@roninjin10 roninjin10 force-pushed the 06-01-feat_add_fee_market.zig branch from 4951447 to 05bba9d Compare June 1, 2025 21:08
@roninjin10 roninjin10 force-pushed the 06-01-feat_fix_build branch from a6b1ee7 to 1a9edb6 Compare June 1, 2025 21:08
@vercel vercel bot temporarily deployed to Preview – node June 1, 2025 21:08 Inactive
@roninjin10 roninjin10 mentioned this pull request Jun 1, 2025
Merged
1 task
@roninjin10 roninjin10 force-pushed the 06-01-feat_add_fee_market.zig branch 2 times, most recently from 50acb7b to 657c699 Compare June 1, 2025 21:15
Base automatically changed from 06-01-feat_add_fee_market.zig to main June 1, 2025 21:16
@roninjin10 roninjin10 force-pushed the 06-01-feat_fix_build branch from 1a9edb6 to 6b620cd Compare June 1, 2025 21:17
@vercel vercel bot temporarily deployed to Preview – node June 1, 2025 21:17 Inactive
@roninjin10 @claude
🔧 fix: Add missing EVM module entrypoint and logger stub
fcf4104 
Added src/evm/evm.zig to export all EVM modules using the implicit module struct pattern.
Added src/evm/EvmLogger.zig stub implementation required by fee_market.zig.

This fixes the build errors and allows successful compilation of all targets.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@roninjin10 roninjin10 force-pushed the 06-01-feat_fix_build branch from 6b620cd to fcf4104 Compare June 1, 2025 21:19
@vercel vercel bot temporarily deployed to Preview – node June 1, 2025 21:19 Inactive
@roninjin10 roninjin10 marked this pull request as ready for review June 1, 2025 21:19
@roninjin10 roninjin10 merged commit 612e2e6 into main Jun 1, 2025
6 of 8 checks passed
@roninjin10 roninjin10 deleted the 06-01-feat_fix_build branch June 1, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@roninjin10
0