8000 ⚡ test: Add memory benchmark by roninjin10 · Pull Request #1758 · evmts/tevm-monorepo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

⚡ test: Add memory benchmark #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 1, 2025
Merged

⚡ test: Add memory benchmark #1758

merged 11 commits into from
Jun 1, 2025

Conversation

roninjin10
Copy link
Collaborator

Description

Concise description of proposed changes

Testing

Explain the quality checks that have been done on the code changes

Additional Information

Your ENS/address:

@vercel Vercel
Copy link
vercel bot commented Jun 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
node ✅ Ready (Inspect) Visit Preview Jun 1, 2025 10:27pm
tevm-monorepo-app 🛑 Canceled (Inspect) Jun 1, 2025 10:27pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
tevm-monorepo-tevm ⬜️ Ignored (Inspect) Jun 1, 2025 10:27pm

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Jun 1, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2645d1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jun 1, 2025 •
edited
Loading

Warning

Rate limit exceeded

@roninjin10 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 12 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 11104f5 and 2645d1d.

📒 Files selected for processing (10)
  • bench/evm/memory_bench.zig (1 hunks)
  • bench/hello_world_bench.zig (0 hunks)
  • build.zig (1 hunks)
  • src/evm/Frame.zig (1 hunks)
  • src/evm/JumpTable.zig (1 hunks)
  • src/evm/Memory.zig (12 hunks)
  • src/evm/Operation.zig (1 hunks)
  • src/evm/Vm.zig (1 hunks)
  • src/evm/evm.zig (1 hunks)
  • test/Evm/memory_test.zig (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

This was referenced Jun 1, 2025
Merged
Merged
Merged
Merged
Merged
@roninjin10 Graphite App
Copy link
Collaborator Author
roninjin10 commented Jun 1, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@roninjin10 roninjin10 mentioned this pull request Jun 1, 2025
Merged
1 task
@vercel vercel bot temporarily deployed to Preview – node June 1, 2025 18:48 Inactive
This was referenced Jun 1, 2025
Merged
Merged
@roninjin10 roninjin10 force-pushed the 06-01-memory_productionize branch from 73549e0 to 12f8c3b Compare June 1, 2025 21:08
@roninjin10 roninjin10 force-pushed the memor_productionize_2 branch from 7358eca to 7f8c5af Compare June 1, 2025 21:08
@roninjin10 roninjin10 mentioned this pull request Jun 1, 2025
Merged
1 task
@roninjin10 roninjin10 force-pushed the 06-01-memory_productionize branch 2 times, most recently from eec0c11 to 65b71fe Compare June 1, 2025 21:20
Base automatically changed from 06-01-memory_productionize to main June 1, 2025 21:21
@roninjin10 roninjin10 changed the title 🔥 remove: Delete hello world benchmark ⚡ test: Add memory benchmark Jun 1, 2025
roninjin10 and others added 9 commits June 1, 2025 14:22
@roninjin10
chore: Refactor zig.vm
3da39c7
@roninjin10 @claude
🔧 fix: Add missing EVM module entrypoint and logger stub
c590279 
Added src/evm/evm.zig to export all EVM modules using the implicit module struct pattern.
Added src/evm/EvmLogger.zig stub implementation required by fee_market.zig.

This fixes the build errors and allows successful compilation of all targets.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@roninjin10 @claude
🔥 remove: Delete hello world benchmark
fbde739 
Per user request: "remove the hello world benchmark"

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@roninjin10 @claude
🚚 rename: Change Memory.zig to memory.zig
3288dd3 
Per user request: "use lowercase_snake_case for all file names"
Used two-step rename via temp file on macOS to handle case-insensitive filesystem

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@roninjin10 @claude
♻️ refactor: Update imports to use lowercase memory.zig
56b84c1 
Updated all imports from Memory.zig to memory.zig across:
- evm.zig
- Frame.zig
- JumpTable.zig
- Operation.zig
- Vm.zig

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@roninjin10 @claude
✅ test: Add comprehensive memory benchmarks
a45f533 
Per user request: "add benchmark for Memory.zig in the bench/evm/ folder"

Created memory_bench.zig with benchmarks for:
- Memory initialization (4KB and 1MB)
- Byte and word operations
- U256 operations
- Memory expansion
- Large data copying
- Memory copy (MCOPY)
- Bounded copy operations
- Slice reading

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@roninjin10 @claude
🔧 build: Update build.zig for new benchmark structure
124acfd 
- Removed hello world benchmark configuration
- Added EVM memory benchmark configuration
- Updated benchmark step to run evm-memory-benchmark

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@roninjin10 @claude
✅ test: Add memory resize and word alignment benchmarks
d07911c 
- Add benchmark for resize operations with various sizes
- Add benchmark for word-aligned resize operations
- Add comprehensive tests for word alignment behavior
- Test exact byte sizing vs word-aligned sizing
- Verify gas calculation based on word boundaries

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@roninjin10 @claude
✨ feat(memory): Add missing functions and improve resize implementation
e92a2ee 
- Add initWithLimit and initWithCapacityAndLimit functions
- Add resizeWordAligned for strict word-aligned memory sizing
- Improve resize function with clearer logic and performance hints
- Add comprehensive documentation for memory sizing approaches
- Align with EVM spec and support flexible memory sizing like revm

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@roninjin10 @claude
📝 docs(memory): Polish and enhance function documentation
8afc062 
- Add comprehensive documentation for all public functions
- Clarify parameter requirements and return values
- Document error conditions for each function
- Add warnings for unsafe operations
- Improve consistency in documentation style
- Fix indentation and formatting issues

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@roninjin10 roninjin10 force-pushed the memor_productionize_2 branch from 7f8c5af to 5a63df9 Compare June 1, 2025 21:22
@roninjin10 roninjin10 force-pushed the memor_productionize_2 branch from 5a63df9 to 2645d1d Compare June 1, 2025 21:23
@vercel vercel bot temporarily deployed to Preview – node June 1, 2025 21:23 Inactive
@roninjin10 roninjin10 marked this pull request as ready for review June 1, 2025 21:23
@roninjin10 roninjin10 merged commit dbb8914 into main Jun 1, 2025
6 of 9 checks passed
@roninjin10 roninjin10 deleted the memor_productionize_2 branch June 1, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@roninjin10
0