8000 Remove/replace old plugin path "org.eclipse.cdt.lsp.editor.ui" · Issue #77 · eclipse-cdt/cdt-lsp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove/replace old plugin path "org.eclipse.cdt.lsp.editor.ui" #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghentschke opened this issue May 16, 2023 · 5 comments
Closed

Remove/replace old plugin path "org.eclipse.cdt.lsp.editor.ui" #77

ghentschke opened this issue May 16, 2023 · 5 comments
Assignees
@ruspl-afed
Milestone
1.0.0

Comments

@ghentschke
Copy link
Contributor

Remove/replace the occurances of the old bundle path org.eclipse.cdt.lsp.editor.ui int the new org.eclipse.cdt.lsp.clangd bundle:
image
@ruspl-afed ruspl-afed self-assigned this May 16, 2023
@ruspl-afed
Copy link
Member

Yes, this is what is in my plan.
UI contributions will go to org.eclipse.cdt.lsp.clangd.editor namespace

@ghentschke
Copy link
Contributor Author

Thank you!

@ghentschke
Copy link
Contributor Author

Maybe we should rename the Activator class org.eclipse.cdt.lsp.internal.clangd.editor.LspEditorUiPlugin into something like LspClangdPlugin WDYT?

@ruspl-afed
Copy link
Member

TBH I think we may not need this class in the nearest future,
But you are right anyway, we need to rename this and some others.

ruspl-afed added a commit to ruspl-afed/eclipse-cdt-lsp that referenced this issue May 17, 2023
@ruspl-afed
[eclipse-cdt#77] Remove/replace old plugin path "org.eclipse.cdt.lsp.…
99f8bed 
…editor.ui"

All except PLUGIN_ID itself are reworked
PLUGIN_ID rework will follow together with preference rework, see
eclipse-cdt#83

Required for eclipse-cdt#77
@ruspl-afed ruspl-afed mentioned this issue May 17, 2023
Merged
ghentschke pushed a commit that referenced this issue May 17, 2023
@ruspl-afed @ghentschke
[#77] Remove/replace old plugin path "org.eclipse.cdt.lsp.editor.ui"
8e6515d 
All except PLUGIN_ID itself are reworked
PLUGIN_ID rework will follow together with preference rework, see
#83

Required for #77
@ruspl-afed
Copy link
Member

Done with #84

@jonahgraham jonahgraham added this to the 1.0.0 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruspl-afed ruspl-afed

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@jonahgraham @ruspl-afed @ghentschke
0