8000 [#77] Remove/replace old plugin path "org.eclipse.cdt.lsp.editor.ui" by ruspl-afed · Pull Request #84 · eclipse-cdt/cdt-lsp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[#77] Remove/replace old plugin path "org.eclipse.cdt.lsp.editor.ui" #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2023
Merged

[#77] Remove/replace old plugin path "org.eclipse.cdt.lsp.editor.ui" #84

merged 1 commit into from
May 17, 2023

Conversation

ruspl-afed
Copy link
Member

All except PLUGIN_ID itself are reworked
PLUGIN_ID rework will follow together with preference rework, see #83

Required for #77

@ruspl-afed
[eclipse-cdt#77] Remove/replace old plugin path "org.eclipse.cdt.lsp.…
99f8bed 
…editor.ui"

All except PLUGIN_ID itself are reworked
PLUGIN_ID rework will follow together with preference rework, see
eclipse-cdt#83

Required for eclipse-cdt#77
@ruspl-afed ruspl-afed requested a review from ghentschke May 17, 2023 07:27
ghentschke
ghentschke approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor
@ghentschke ghentschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@ghentschke ghentschke merged commit 8e6515d into eclipse-cdt:master May 17, 2023
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this pull request May 17, 2023
@ghentschke
Fix old property test
fff7d21 
the id of the property test has been renamed in eclipse-cdt#84. This file was
missed.
@ghentschke ghentschke mentioned this pull request May 17, 2023
Merged
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this pull request May 17, 2023
@ghentschke
Fix old property test
343cec6 
the id of the property test has been renamed in eclipse-cdt#84. This file was
missed.
ruspl-afed pushed a commit that referenced this pull request May 17, 2023
@ghentschke
Fix old property test (#89)
7485293 
the id of the property test has been renamed in #84. This file was
missed.
@ruspl-afed ruspl-afed deleted the 77-1 branch June 3, 2023 07:25
@ruspl-afed ruspl-afed mentioned this pull request Jun 12, 2023
Closed
@jonahgraham jonahgraham added this to the 1.0.0 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghentschke ghentschke ghentschke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ruspl-afed @ghentschke @jonahgraham
0