Don't package arm64 on amd64 workers #43026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request doesn't have a |
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
1990fa0 to
67a0840
Compare
This commit is the counterpart of elastic#43019 for the DRA packaging pipeline. It ensures that arm64 packages get built without qemu emulation on dedicated arm64 workers.
67a0840 to
cfc0694
Compare
dliappis
commented
Mar 5, 2025
|
Generally LGTM. One thing that confuses me. For auditbeat we had 22 build artifacts, and now we have 26 (10 + 16). |
This is concerning. Let's look at it. |
@pazone here's the diff: So the 4 extra files are: e.g. we now seem to be also producing an arm64 docker image for wolfi which apparently isn't used since the DRA snapshot (in dry_run mode) shows that the same 144 artifacts will be used, we are ok, WDYT? |
This reverts commit 73c9491.
pkoutsovasilis
approved these changes
Mar 5, 2025
pchila
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
LGTM
I agree with @dliappis that creating more artifact that are not configured for the DRA project is not a big problem although I would be curious to understand exactly what makes the new auditbeat* docker images appear (I guess that there are some clauses about ARCH in the packaging code).
@pazone / @pchila Whereas the last successful build on main produced also 26 (22+4): https://buildkite.com/elastic/beats-packaging-pipeline/builds/2626#01956241-0b50-4f4c-b2dd-d3fa278c7e13 So I think we are good. |
alexsapran
approved these changes
Mar 6, 2025
v1v
added a commit
to v1v/beats
that referenced
this pull request
Mar 6, 2025
…-packaging-steps * upstream/main: filebeat: make deep copy before notifying of config change (elastic#42992) [metricbeat] Add a new 'match_by_parent_instance' option to 'perfmon' module (elastic#43002) Don't package arm64 on amd64 workers (elastic#43026) [REVERT] Update Stack Monitoring data stream to 9 (elastic#43052) FIPS Build (elastic#42402) refactor: drop custom fsync implementation (elastic#42066) Update CHANGELOG.asciidoc docs: Prepare Changelog for 8.17.3 (elastic#42980) (elastic#43029) Fix boolean key in security pipelines and sync pipelines with integration. (elastic#43027) Skip test case for sequoia (elastic#42996) [main](backport elastic#42976) docs: Prepare Changelog for 8.16.5 (elastic#43005) x-pack/filebeat/input/entityanalytics/provider/activedirectory: do not consider computers to be users (elastic#42796)
jlind23
added a commit
that referenced
this pull request
Mar 10, 2025
* Don't package arm64 on amd64 workers (#43026) This commit is the counterpart of #43019 for the DRA packaging pipeline. It ensures that arm64 packages get built without qemu emulation on dedicated arm64 workers. (cherry picked from commit 2c6e5af) * Build functionbeat on arm64 too --------- Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com> Co-authored-by: Julien Lind <julien.lind@elastic.co>
6 tasks
dliappis
added a commit
that referenced
this pull request
Mar 12, 2025
This commit is the counterpart of #43019 for the DRA packaging pipeline. It ensures that arm64 packages get built without qemu emulation on dedicated arm64 workers. (cherry picked from commit 2c6e5af) Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com> Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>
This was referenced Mar 12, 2025
6 tasks
6 tasks
mauri870
pushed a commit
to mauri870/beats
that referenced
this pull request
Jun 4, 2025
This commit is the counterpart of elastic#43019 for the DRA packaging pipeline. It ensures that arm64 packages get built without qemu emulation on dedicated arm64 workers.
mauri870
added a commit
to mauri870/beats
that referenced
this pull request
Jun 4, 2025
This is an amalgamated commit of: - elastic#43026 - elastic#43280 - elastic#43387
mauri870
added a commit
to mauri870/beats
that referenced
this pull request
Jun 6, 2025
This is an amalgamated commit of: - elastic#43026 - elastic#43280 - elastic#43387
mauri870
added a commit
to mauri870/beats
that referenced
this pull request
Jun 7, 2025
This is an amalgamated commit of: - elastic#43026 - elastic#43280 - elastic#43387 - elastic#43406 - elastic#42705
mauri870
added a commit
to mauri870/beats
that referenced
this pull request
Jun 7, 2025
This is an amalgamated commit of: - elastic#43026 - elastic#43280 - elastic#43387 - elastic#43406 - elastic#42705
mauri870
added a commit
that referenced
this pull request
Jun 16, 2025
* Amalgamated commit with missing buildkite backports This is an amalgamated commit of: - #43026 - #43280 - #43387 - #43406 - #42705 * install libsystemd-dev to fix linter issues * remove packaging not available in 7.17 branch * install npcap on windows * try installing npcap with winget for silent installation * try and install npcap 0.86 manually * remove packaging for beats not in 7.17 * it is WinPcap that we need for pcap.h * Update .buildkite/packaging.pipeline.yml Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> * Update .buildkite/packaging.pipeline.yml Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> * Update .buildkite/packaging.pipeline.yml Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> --------- Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This commit is the counterpart of
#43019 for the DRA packaging pipeline.
It ensures that arm64 packages get built without qemu emulation on dedicated arm64 workers.
How to test this PR locally
Successful BK link:
https://buildkite.com/elastic/beats-packaging-pipeline/builds/2656#01956655-e341-4ec5-a3a2-859c4fac28a8
and another one using the latest commit: https://buildkite.com/elastic/beats-packaging-pipeline/builds/2664
where both staging + snapshot got triggered using
DRA_DRY_RUN=falseAdditionally, I compared the DRA job output for snapshot artifacts from the above triggered job , against the latest successful DRA build on main and the results were identical.
Related issues
Closes #43042
Screenshots