8000 [7.17] Upgrade go version to 1.23.8 by faec · Pull Request #44585 · elastic/beats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[7.17] Upgrade go version to 1.23.8 #44585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

faec
Copy link
Contributor
@faec faec commented May 30, 2025

Upgrade the 7.17 branch to golang 1.23.8, required to address CVEs.

@faec faec self-assigned this May 30, 2025
@faec faec added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label May 30, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 30, 2025
@faec faec marked this pull request as ready for review May 30, 2025 15:42
@faec faec requested review from a team as code owners May 30, 2025 15:42
@faec faec requested review from gizas and constanca-m and removed request for a team May 30, 2025 15:42
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@faec faec requested review from mauri870 and khushijain21 and removed request for a team May 30, 2025 15:42
@faec faec changed the title Upgrade go version to 1.23.8 [7.17] Upgrade go version to 1.23.8 May 30, 2025
@mauri870
Copy link
Member
mauri870 commented May 30, 2025

@faec Looks like we stopped publishing crossbuild images for debian7 starting from 1.23.7. The 7.17 branch needs to stay in debian 7 because of glibc constraints. I assume once we merge elastic/golang-crossbuild#621 we should start publishing debian7 images again.

We'll likely jump into 1.24 once that is ready #43984.

@cmacknz
Copy link
Member
cmacknz commented May 30, 2025

@faec Looks like we stopped publishing crossbuild images for debian7 starting from 1.23.7. The 7.17 branch needs to stay in debian 7 because of glibc constraints. I assume once we merge elastic/golang-crossbuild#621 we should start publishing debian7 images again.

Ugh, I was hoping we would be able to bypass waiting for that by staying on 1.23.

@mauri870
Copy link
Member
mauri870 commented Jun 3, 2025

/test

@mauri870
8000 Copy link
Member
mauri870 commented Jun 3, 2025

Hmm, it seems there are images that don't exist even after merging elastic/golang-crossbuild#621.

For example docker pull docker.elastic.co/beats-dev/golang-crossbuild:1.23.8-arm results in manifest unknown. At least we can pull the debian7 based ones now.

cc @v1v

@mauri870
Copy link
Member
mauri870 commented Jun 3, 2025

I think we might be missing some backport here, perhaps #43026? I'm going to test it now...

@v1v
Copy link
Member
v1v commented Jun 3, 2025

For example docker pull docker.elastic.co/beats-dev/golang-crossbuild:1.23.8-arm results in manifest unknown. At least we can pull the debian7 based ones now.

There were some changes about some qemu issues, that forced us to run amr64 on arm64 workers.

That's a change done in main and the release branches but 7.17, there are some backports that need to be done:

Do you mind cherry-picking them in this PR and see how it goes? I don't know how the conflicts might look like, but if chery-pick is a bit complex in terms of conflicts, alternatively, it will be a matter of configuring those arm64 steps to also build on arm64.

@mauri870
Copy link
Member
mauri870 commented Jun 3, 2025

Do you mind cherry-picking them in this PR and see how it goes? I don't know how the conflicts might look like, but if chery-pick is a bit complex in terms of conflicts, alternatively, it will be a matter of configuring those arm64 steps to also build on arm64.

Thanks, I remember the qemu issue. Yeah, I'll try to cherry pick them and see if that solves the issue.

@mauri870
Copy link
Member
mauri870 commented Jun 4, 2025

@v1v Unfortunately, I couldn't get things to work. To experiment with the backports, I opened a separate PR at #44643. There were too many conflicts when cherry-picking the original PRs, so I decided to apply the changes manually. I may have messed something up (which is quite likely), or we might still be missing some backports. Would you mind taking a look? We might need someone more experienced with the Buildkite pipelines to get this working.

@v1v
Copy link
Member
v1v commented Jun 5, 2025

Would you mind taking a look? We might need someone more experienced with the Buildkite pipelines to get this working

Please see my comment:

@mauri870
Copy link
Member

For cross-reference, the pipeline issues are fixed in #44701.

@mauri870
Copy link
Member

@faec Can you update heartbeat/Dockerfile? Thanks

--- a/heartbeat/Dockerfile
+++ b/heartbeat/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.23.6
+FROM golang:1.23.8

 RUN \

@cmacknz
Copy link
Member
cmacknz commented Jun 17, 2025

Closing in favour of #43984

@cmacknz cmacknz closed this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0