-
Notifications
You must be signed in to change notification settings - Fork 5k
[7.17] Upgrade go version to 1.23.8 #44585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
@faec Looks like we stopped publishing crossbuild images for debian7 starting from 1.23.7. The 7.17 branch needs to stay in debian 7 because of glibc constraints. I assume once we merge elastic/golang-crossbuild#621 we should start publishing debian7 images again. We'll likely jump into 1.24 once that is ready #43984. |
Ugh, I was hoping we would be able to bypass waiting for that by staying on 1.23. |
/test |
Hmm, it seems there are images that don't exist even after merging elastic/golang-crossbuild#621. For example cc @v1v |
I think we might be missing some backport here, perhaps #43026? I'm going to test it now... |
There were some changes about some qemu issues, that forced us to run amr64 on arm64 workers. That's a change done in
Do you mind cherry-picking them in this PR and see how it goes? I don't know how the conflicts might look like, but if chery-pick is a bit complex in terms of conflicts, alternatively, it will be a matter of configuring those arm64 steps to also build on arm64. |
Thanks, I remember the qemu issue. Yeah, I'll try to cherry pick them and see if that solves the issue. |
@v1v Unfortunately, I couldn't get things to work. To experiment with the backports, I opened a separate PR at #44643. There were too many conflicts when cherry-picking the original PRs, so I decided to apply the changes manually. I may have messed something up (which is quite likely), or we might still be missing some backports. Would you mind taking a look? We might need someone more experienced with the Buildkite pipelines to get this working. |
Please see my comment: |
For cross-reference, the pipeline issues are fixed in #44701. |
@faec Can you update --- a/heartbeat/Dockerfile
+++ b/heartbeat/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.23.6
+FROM golang:1.23.8
RUN \ |
Closing in favour of #43984 |
Upgrade the 7.17 branch to golang 1.23.8, required to address CVEs.