Enforce that PRs are not opened from the 'master' branch of a fork #6899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/6899-emilkenforce-no-prs-from-master |
1 task
lucasmerlin
reviewed
Apr 30, 2025
|
Just want to comment, that it should be possible to push to master branch of other repository, see for example tafia/quick-xml#857, where I made a force-push to master branch of a contributor. |
|
I believe it is possible if the user has not protected their master branch (which they probably should). And force-pushing to someone else |
lucasmerlin
approved these changes
Apr 30, 2025
|
Tested sucessfully in |
grtlr
pushed a commit
to rerun-io/rerun
that referenced
this pull request
May 7, 2025
### Related * Based on emilk/egui#6899 * Tested successfully in emilk/egui#7028 ## What Fail all PRs that are opened from the `main` branch of the fork. ## Why PR:s opened from the `main` branch cannot be collaborated on. That is, we maintainers cannot push our own commits to it (e.g. to fix smaller problems with it before merging). This is because `main` is usually protected (and even if it isn't, it probably _should_ be, and we should not push commits directly into the `main` of some fork)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fail all PRs that are opened from the master/main branch of the fork.
Why
PR:s opened from the
masterbranch cannot be collaborated on. That is, we maintainers cannot push our own commits to it (e.g. to fix smaller problems with it before merging).How
Untested code straight from Claude 3.7 😅