8000 Test that we cannot open a PR from the `master` branch by lucasmerlin · Pull Request #7028 · emilk/egui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test that we cannot open a PR from the master branch #7028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Test that we cannot open a PR from the master branch #7028

wants to merge 1 commit into from

Conversation

lucasmerlin
Copy link
Collaborator

@emilk emilk added the do-not-merge Do not merge yet, but you can still review it label May 6, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented May 6, 2025

Preview available at https://egui-pr-preview.github.io/pr/7028-master
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@github-actions GitHub Actions
Copy link
github-actions bot commented May 6, 2025

⚠️ ERROR: Pull requests from the master/main branch of forks are not allowed, because it prevents maintainers from contributing to your PR. Please create a feature branch in your fork and submit the PR from that branch instead.

@lucasmerlin
Copy link
Collaborator Author

Nice!

@lucasmerlin lucasmerlin closed this May 6, 2025
This was referenced May 6, 2025
Merged
Merged
@emilk emilk changed the title Test commit (Dont merge) Test that we cannot open a PR from the master branch May 6, 2025
grtlr pushed a commit to rerun-io/rerun that referenced this pull request May 7, 2025
@emilk
Forbid opening PRs from main branch of a fork (#9891)
5511bd3 
### Related
* Based on emilk/egui#6899
* Tested successfully in emilk/egui#7028

## What
Fail all PRs that are opened from the `main` branch of the fork.

## Why
PR:s opened from the `main` branch cannot be collaborated on. That is,
we maintainers cannot push our own commits to it (e.g. to fix smaller
problems with it before merging). This is because `main` is usually
protected (and even if it isn't, it probably _should_ be, and we should
not push commits directly into the `main` of some fork)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge Do not merge yet, but you can still review it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasmerlin @emilk
0