Wi handle all zero signal #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all zero at the detectors, with suggestions to what to do differently
…placing zeros with small constants to keep gradient flow
gomezzz
approved these changes
Mar 28, 2022
|
|
||
| if _mean_square(signals[0]) <= 1e-15: | ||
| raise ValueError( | ||
| "The freen space signal is all zero. Increase the number of FDTD_niter to ensure that the signal reaches the detctor." |
There was a problem hiding this comment.
Suggested change
| "The freen space signal is all zero. Increase the number of FDTD_niter to ensure that the signal reaches the detctor." | |
| "The free space signal is all zero. Increase the number of FDTD_niter to ensure that the signal reaches the detctor." |
| ) | ||
| if _mean_square(signals[1]) <= 1e-15: | ||
| logger.warning( | ||
| "WARNING:The signal trough the material layer(s) never reaches the detector. Increase FDTD_niter to ensure that the signal reaches the detector. The signal usually travels slower in a material than in free space " |
There was a problem hiding this comment.
Suggested change
| "WARNING:The signal trough the material layer(s) never reaches the detector. Increase FDTD_niter to ensure that the signal reaches the detector. The signal usually travels slower in a material than in free space " | |
| "WARNING:The signal trough the material layer(s) never reaches the detector. Increase FDTD_niter to ensure that the signal reaches the detector. The signal usually travels slower in a material than in free space." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Throws error when signal never reaches the detectors
Resolved Issues