8000 Wi handle all zero signal by torbjornstoro · Pull Request #70 · esa/NIDN · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Wi handle all zero signal #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 29, 2022
Merged

Wi handle all zero signal #70

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
98e3c46
Added check which raises either an error or warning if the signal is …
torbjornstoro Mar 21, 2022
36dab5a
changed warning to use warnings module
torbjornstoro Mar 21, 2022
5bd7525
Changed warning to logger, and added offset to zero signal, due to re…
torbjornstoro Mar 28, 2022
594b12f
Removed unused import
torbjornstoro Mar 28, 2022
24cb48e
Corrected grammar in comments
torbjornstoro Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions nidn/fdtd_integration/calculate_transmission_reflection_coefficients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ def calculate_transmission_reflection_coefficients(
# Thus, most of the signal present is the unreflected signal, which must be removed.
true_reflection = reflection_signals[1] - reflection_signals[0]

_check_for_all_zero_signal(transmission_signals)
_check_for_all_zero_signal(reflection_signals)

if time_to_frequency_domain_method.upper() == "MEAN SQUARE":
transmission_coefficient = _mean_square(transmission_signals[1]) / _mean_square(
transmission_signals[0]
Expand Down Expand Up @@ -96,3 +99,15 @@ def _fft(signal, cfg: DotMap):
yf = rfft(tensor_signal)
xf = rfftfreq(cfg.FDTD_niter, sampling_frequencies)
return xf, yf


def _check_for_all_zero_signal(signals):

if _mean_square(signals[0]) <= 1e-15:
raise ValueError(
"The free space signal is all zero. Increase the number of FDTD_niter to ensure that the signal reaches the detctor."
)
if _mean_square(signals[1]) <= 1e-15:
logger.warning(
"WARNING:The signal trough the material layer(s) never reaches the detector. Increase FDTD_niter to ensure that the signal reaches the detector. The signal usually travels slower in a material than in free space."
)
0