8000 fix(Example) by wesleycho · Pull Request #59 · facebook/flow · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(Example) #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2014
Merged

fix(Example) #59

merged 2 commits into from
Nov 19, 2014

Conversation

wesleycho
Copy link
Contributor
  • Change to account for length(undefined) throwing error

@wesleycho
fix(Example)
50e0385 
- Change to account for length(undefined) throwing error
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gabelevi
Copy link
Contributor

Whoops, a flow error in the docs! Thanks for noticing!

Would you mind updating this to be x != null? While your change is functionally correct (the empty string DOES have a length of 0) I think the point of the example is teaching how to deal with a nullable type, and in general != is the preferred way.

@wesleycho
Copy link
Contributor Author

Sure - technically my change was wrong too due to objects and functions, but I understand the rationale.

@gabelevi
Copy link
Contributor

Great, thanks!

gabelevi added a commit that referenced this pull request Nov 19, 2014
@gabelevi
Merge pull request #59 from wesleycho/fix/null-example
84dcacf 
fix(Example)
@gabelevi gabelevi merged commit 84dcacf into facebook:master Nov 19, 2014
dsereni added a commit that referenced this pull request Nov 20, 2014
@dsereni
Added changelog for 0.1.1 release
dfa8531 
- [Issue #4] Typecheck .jsx files
- [Issue #22] Return a nonzero exit code from 'flow check' if there are errors
- [IRC report] Autostart the Flow server on all commands
- Improve the printing of types in 'flow suggest'
- Add a --timeout option to all commands
- [PR #27] Clearer error message when 'flow init' hasn't been run
- [PR #39] Fix to Emacs bindings
- [PR #53] Support node modules that end in .js
- [PR #59] Fix example
- [PR #65] Fix dependencies in flux-chat example
- [PR #66] Add type definitions for HTMLCanvasElement
jeffmo added a commit to jeffmo/flow that referenced this pull request Jul 31, 2015
@jeffmo
Merge pull request facebook#59 from gabelevi/interface
2a4683a 
Parse interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wesleycho @facebook-github-bot @gabelevi @jonnybojangles
0