Add type definitions for HTMLCanvasElement. #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Looks good to me. Thanks! |
gabelevi
added a commit
that referenced
this pull request
Nov 19, 2014
Add type definitions for HTMLCanvasElement.
dsereni
added a commit
that referenced
this pull request
Nov 20, 2014
- [Issue #4] Typecheck .jsx files - [Issue #22] Return a nonzero exit code from 'flow check' if there are errors - [IRC report] Autostart the Flow server on all commands - Improve the printing of types in 'flow suggest' - Add a --timeout option to all commands - [PR #27] Clearer error message when 'flow init' hasn't been run - [PR #39] Fix to Emacs bindings - [PR #53] Support node modules that end in .js - [PR #59] Fix example - [PR #65] Fix dependencies in flux-chat example - [PR #66] Add type definitions for HTMLCanvasElement
|
🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds only the definitions of
HTMLCanvasElement. To real usecases, we need to add definitions ofCanvasRenderingContext2D.#61