8000 Upgrade to go 1.24.0 minimum version by anthony-gomez-fastly · Pull Request #668 · fastly/go-fastly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade to go 1.24.0 minimum version #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

Upgrade to go 1.24.0 minimum version #668

merged 2 commits into from
Apr 30, 2025

Conversation

anthony-gomez-fastly
Copy link
Contributor
@anthony-gomez-fastly anthony-gomez-fastly commented Apr 22, 2025 •
edited
Loading

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Description

This will upgrade go to 1.24.0, allowing us to take advantage of the new go tool functionality amongst other improvements

@anthony-gomez-fastly anthony-gomez-fastly force-pushed the upgrade-to-go-1.24.0 branch 5 times, most recently from 1af5ba1 to 16d1e20 Compare April 24, 2025 16:13
@anthony-gomez-fastly anthony-gomez-fastly changed the title feat(go.mod): upgrade to go 1.24.0 minimum version Upgrade to go 1.24.0 minimum version Apr 24, 2025
@anthony-gomez-fastly anthony-gomez-fastly force-pushed the upgrade-to-go-1.24.0 branch 4 times, most recently from 4e07334 to a65c774 Compare April 24, 2025 16:26
anthony-gomez-fastly
anthony-gomez-fastly commented Apr 24, 2025
View reviewed changes
anthony-gomez-fastly
anthony-gomez-fastly commented Apr 24, 2025
View reviewed changes
@anthony-gomez-fastly anthony-gomez-fastly marked this pull request as ready for review April 25, 2025 16:19
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner April 25, 2025 16:19
philippschulte
philippschulte approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member
@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please ask Kevin to review it as well. Thanks.

@anthony-gomez-fastly
Copy link
Contributor Author

@kpfleming when you have a sec plz review

kpfleming
kpfleming approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor
@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@anthony-gomez-fastly anthony-gomez-fastly merged commit 4434d32 into main Apr 30, 2025
7 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the upgrade-to-go-1.24.0 branch April 30, 2025 18:24
Integralist pushed a commit that referenced this pull request May 19, 2025
@anthony-gomez-fastly @Integralist
Upgrade to go 1.24.0 minimum version (#668)
178657e 
This will upgrade go to 1.24.0, allowing us to take advantage of the new
`go tool` functionality amongst other improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpfleming kpfleming kpfleming approved these changes

@philippschulte philippschulte philippschulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anthony-gomez-fastly @kpfleming @philippschulte
0