8000 Upgrade to go 1.24.0 minimum version by anthony-gomez-fastly · Pull Request #668 · fastly/go-fastly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade to go 1.24.0 minimum version #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

Upgrade to go 1.24.0 minimum version #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
415338b
feat(go.mod): upgrade to go 1.24.0 minimum version
anthony-gomez-fastly Apr 22, 2025
9bdb4e0
Merge branch 'main' into upgrade-to-go-1.24.0
anthony-gomez-fastly Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/pr_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ jobs:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: 1.2 10000 3.x
- name: Installing necessary tools
run: make dev-dependencies
shell: bash
go-version: 1.24.x
- name: Check Module
run: make check-mod
shell: bash
- name: Installing necessary tools
run: make mod-download
shell: bash
- name: Check Imports
run: make check-imports
shell: bash
Expand All @@ -43,7 +43,7 @@ jobs:
test:
strategy:
matrix:
go-version: [1.23.x, 1.24.x]
go-version: [1.24.x]
platform: [ubuntu-latest]
runs-on: ${{ matrix.platform }}
steps:
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

### Enhancements:

- feat(go.mod): upgrade to go 1.24.0 minimum version ([#668](https://github.com/fastly/go-fastly/pull/668))

### Bug fixes:

### Dependencies:
Expand Down
20 changes: 7 additions & 13 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,34 +27,27 @@ FASTLY_API_KEY ?=
# Enables support for tools such as https://github.com/rakyll/gotest
TEST_COMMAND ?= $(GO) test

all: mod-download dev-dependencies tidy fmt fiximports test vet staticcheck semgrep ## Runs all of the required cleaning and verification targets.
all: mod-download tidy fmt fiximports test vet staticcheck semgrep ## Runs all of the required cleaning and verification targets.
.PHONY: all

mod-download: ## Downloads the Go module.
@echo "==> Downloading Go module"
@$(GO) mod download
.PHONY: mod-download

dev-dependencies: ## Downloads the necessary dev dependencies.
@echo "==> Downloading development dependencies"
@$(GO) install honnef.co/go/tools/cmd/staticcheck@v0.6.0
@$(GO) install golang.org/x/tools/cmd/goimports@v0.30.0
@if [[ "$$(uname)" == 'Darwin' ]]; then brew install semgrep; fi
.PHONY: dev-dependencies

tidy: ## Cleans the Go module.
@echo "==> Tidying module"
@$(GO) mod tidy
.PHONY: tidy

fmt: ## Properly formats Go files and orders dependencies.
@echo "==> Running gofmt"
@gofmt -s -w fastly internal tools
@gofmt -s -w fastly internal
.PHONY: fmt

fiximports: ## Properly formats and orders imports.
@echo "==> Fixing imports"
@goimports -w fastly internal tools
@$(GO) tool goimports -w fastly internal
.PHONY: fiximports

test: ## Runs the test suite with VCR mocks enabled.
Expand All @@ -69,12 +62,13 @@ vet: ## Identifies common errors.

staticcheck: ## Runs the staticcheck linter.
@echo "==> Running staticcheck"
@staticcheck -version
@staticcheck ./...
@$(GO) tool staticcheck -version
@$(GO) tool staticcheck ./...
.PHONY: staticcheck

semgrep: ## Run semgrep checker.
if command -v semgrep &> /dev/null; then semgrep ci --config auto --exclude-rule generic.secrets.security.detected-private-key.detected-private-key $(SEMGREP_ARGS); fi
@if [[ "$$(uname)" == 'Darwin' ]]; then brew install semgrep; fi
@if command -v semgrep &> /dev/null; then semgrep ci --config auto --exclude-rule generic.secrets.security.detected-private-key.detected-private-key $(SEMGREP_ARGS); fi
.PHONY: semgrep

test-race: ## Runs the test suite with the -race flag to identify race conditions, if they exist.
Expand Down
17 changes: 11 additions & 6 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
module github.com/fastly/go-fastly/v10

go 1.24.0

toolchain go1.24.2

require (
github.com/dnaeon/go-vcr v1.2.0
github.com/google/go-cmp v0.7.0
Expand All @@ -10,22 +14,23 @@ require (
github.com/peterhellberg/link v1.2.0
github.com/stretchr/testify v1.10.0
golang.org/x/crypto v0.37.0
golang.org/x/tools v0.32.0
honnef.co/go/tools v0.6.1
)

require (
github.com/BurntSushi/toml v1.5.0 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
golang.org/x/exp/typeparams v0.0.0-20250106191152-7588d65b2ba8 // indirect
golang.org/x/exp/typeparams v0.0.0-20250408133849-7e4ce0ab07d0 // indirect
golang.org/x/mod v0.24.0 // indirect
golang.org/x/sync v0.13.0 // indirect
golang.org/x/sys v0.32.0 // indirect
golang.org/x/tools v0.32.0 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
honnef.co/go/tools v0.6.1 // indirect
)

go 1.23.0

toolchain go1.23.7
tool (
golang.org/x/tools/cmd/goimports
honnef.co/go/tools/cmd/staticcheck
)
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOf
github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
golang.org/x/crypto v0.37.0 h1:kJNSjF/Xp7kU0iB2Z+9viTPMW4EqqsrywMXLJOOsXSE=
golang.org/x/crypto v0.37.0/go.mod h1:vg+k43peMZ0pUMhYmVAWysMK35e6ioLh3wB8ZCAfbVc=
golang.org/x/exp/typeparams v0.0.0-20250106191152-7588d65b2ba8 h1:EN2027N+i+Tda4MiYFv7Mb0WAxf/gfHdpF2QAtplC9s=
golang.org/x/exp/typeparams v0.0.0-20250106191152-7588d65b2ba8/go.mod h1:AbB0pIl9nAr9wVwH+Z2ZpaocVmF5I4GyWCDIsVjR0bk=
golang.org/x/exp/typeparams v0.0.0-20250408133849-7e4ce0ab07d0 h1:oMe07YcizemJ09rs2kRkFYAp0pt4e1lYLwPWiEGMpXE=
golang.org/x/exp/typeparams v0.0.0-20250408133849-7e4ce0ab07d0/go.mod h1:LKZHyeOpPuZcMgxeHjJp4p5yvxrCX1xDvH10zYHhjjQ=
golang.org/x/mod v0.24.0 h1:ZfthKaKaT4NrhGVZHO1/WDTwGES4De8KtWO0SIbNJMU=
golang.org/x/mod v0.24.0/go.mod h1:IXM97Txy2VM4PJ3gI61r1YEk/gAj6zAHN3AdZt6S9Ww=
golang.org/x/sync v0.13.0 h1:AauUjRAJ9OSnvULf/ARrrVywoJDy0YS2AwQ98I37610=
Expand Down
14 changes: 0 additions & 14 deletions tools/tools.go
View file
Open in desktop

This file was deleted.

0