8000 sys-apps/ignition: pull release 2.21.0 by tormath1 · Pull Request #2775 · flatcar/scripts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

sys-apps/ignition: pull release 2.21.0 #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 28, 2025
Merged

sys-apps/ignition: pull release 2.21.0 #2775

merged 4 commits into from
Mar 28, 2025

Conversation

tormath1
Copy link
Contributor
@tormath1 tormath1 commented Mar 26, 2025 •
edited
Loading

In this PR, we upgrade Ignition to its latest version 2.21.0

Testing done

$ sudo emerge -v ignition
...
$ ls -l /usr/libexec/ignition-rmcfg
lrwxrwxrwx 1 root root 17 Mar 27 15:57 /usr/libexec/ignition-rmcfg -> /usr/bin/ignition
$ /usr/libexec/ignition-rmcfg --help
Usage: /usr/libexec/ignition-rmcfg [options]
...

Note for reviewers: This upgrade was ok to backport the downstream patches - looking forward to deprecated the Ignition v2 support though...

tormath1 added 3 commits March 26, 2025 15:23
@tormath1
sys-apps/ignition: pull release 2.21.0
7c79347 
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1
sys-apps/ignition: apply Flatcar modifications
687031f 
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1
changelog: add entry
17ecbee 
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1 tormath1 self-assigned this Mar 26, 2025
@tormath1 tormath1 added the main label Mar 26, 2025
@tormath1 tormath1 moved this to ✅ Testing / in Review in Flatcar tactical, release planning, and roadmap Mar 26, 2025
@tormath1 tormath1 marked this pull request as ready for review March 27, 2025 08:35
@tormath1 tormath1 requested a review from a team March 27, 2025 08:35
@chewi
Copy link
Contributor
chewi commented Mar 27, 2025

That's increased the image size by 31MB, is that expected?

@github-actions GitHub Actions
Copy link
github-actions bot commented Mar 27, 2025 •
edited
Loading

Build action triggered: https://github.com/flatcar/scripts/actions/runs/14126812592

@tormath1
Copy link
Contributor Author

That's increased the image size by 31MB, is that expected?

Yeah, 15mb for ignition and 15mb for ignition-rmcfg - that's a side effect of this Azure feature I guess (as it pulls more of the Azure SDK): coreos/ignition#1923

Note that this is not in the initramfs but on the disk. ignition and ignition-rmcfg are actually the same binaries. I'm wondering if we could not symlink ignition-rmcfg to ignition (https://github.com/coreos/ignition/blob/b111af12e9c289f910b8bb9a561d4cc28b22736e/internal/main.go#L37-L47)

chewi
chewi approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor
@chewi chewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I know it's not in the initramfs, so I'm not really worried, just wanted to check it was expected. Symlinking sounds good. I'll leave that with you.

@tormath1
Copy link
Contributor Author

Yeah, I know it's not in the initramfs, so I'm not really worried, just wanted to check it was expected. Symlinking sounds good. I'll leave that with you.

Raised to FCOS folks: coreos/ignition#2045 - I will hold this while I'm investigating on symlinking ignition-rmcfg to ignition.

@tormath1
sys-apps/ignition: symlink ignition-rmcfg
2c60a08 
With the recent Ignition upgrade, Ignition took 15MB and two times as we
ship ignition-rmcfg as a copy of ignition.

Let's symlink ignition-rmcfg to save some space to migitate a bit the
size increase.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1 tormath1 removed the on-hold label Mar 28, 2025
@tormath1
Copy link
Contributor Author

Yeah, I know it's not in the initramfs, so I'm not really worried, just wanted to check it was expected. Symlinking sounds good. I'll leave that with you.

Raised to FCOS folks: coreos/ignition#2045 - I will hold this while I'm investigating on symlinking ignition-rmcfg to ignition.

@chewi I symlinked ignition-rmcfg to ignition. For the record, this "affects" only vmware / virtualbox setup as this is supported only for those providers (ignition-rmcfg deletes the Ignition configuration from the user-data once the provisioning done and this is supported only here)

19:30:53  All 1 just deleted files:
19:30:53  
19:30:53  ./usr/libexec/ignition-rmcfg (27157792 bytes, 26521 kbytes, 25 mbytes)
19:30:53  
19:30:53  Top 10 grown in size files (of 324 files total):
19:30:53  
19:30:53  ./usr/bin/ignition by 16747408 bytes (16354 kbytes, 15 mbytes) from 27157792 bytes (26521 kbytes, 25 mbytes) to 43905200 bytes (42876 kbytes, 41 mbytes)

We gain 15mb from one side but we lost 25mb from the other side, it's a win.

Tests have been restarted only for VMWare, we can see that ignition-delete-config.service runs correctly:

Mar 27 18:56:52.947182 systemd[1]: Starting ignition-delete-config.service - Ignition (delete config)...
...
Mar 27 18:56:53.075571 systemd[1]: Finished ignition-delete-config.service - Ignition (delete config).

The size increase is tracked here: coreos/ignition#2045

@chewi
Copy link
Contributor
chewi commented Mar 28, 2025

Ship it!

@tormath1 tormath1 merged commit b9ea88f into main Mar 28, 2025
1 of 3 checks passed
@github-project-automation github-project-automation bot moved this from ✅ Testing / in Review to Implemented in Flatcar tactical, release planning, and roadmap Mar 28, 2025
@tormath1 tormath1 deleted the tormath1/ignition branch March 28, 2025 12:14
@github-actions github-actions bot mentioned this pull request Apr 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chewi chewi chewi approved these changes

Assignees

@tormath1 tormath1

Labels
main
Projects
Flatcar tactical, release planning, and roadmap
Status: Implemented
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tormath1 @chewi
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
0