8000 Adjust constraints in templates by mit-mit · Pull Request #68437 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adjust constraints in templates #68437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2020
Merged

Adjust constraints in templates #68437

merged 1 commit into from
Oct 19, 2020

Conversation

mit-mit
Copy link
Member
@mit-mit mit-mit commented Oct 18, 2020

Description

Adjust constraints to only state a minimum SDK

Fixes #68143

Tests

n/a

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 18, 2020
@google-cla google-cla bot added the cla: yes label Oct 18, 2020
@mit-mit mit-mit requested a review from jonahwilliams October 18, 2020 11:03
jonahwilliams
jonahwilliams approved these changes Oct 18, 2020
View reviewed changes
Copy link
Member
@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac build_gallery has failed. Please fix the issues identified (or deflake) before re-applying this label.

@mit-mit mit-mit merged commit c97ea71 into flutter:master Oct 19, 2020
@mit-mit mit-mit deleted the templatefix branch October 19, 2020 15:17
christopherfujino pushed a commit to chris-forks/flutter that referenced this pull request Oct 28, 2020
@mit-mit @christopherfujino
Adjust constraints (flutter#68437)
8381ce7
@mit-mit mit-mit mentioned this pull request Oct 29, 2020
Closed
amirh
amirh reviewed Oct 29, 2020
View reviewed changes
Copy link
Contributor
@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

christopherfujino added a commit that referenced this pull request Oct 29, 2020
@christopherfujino @xu-baolin @mit-mit
[flutter_releases] Flutter 1.22.3 framework cherrypicks (#69234)
8874f21 
* Fix TextField bug when the formatter repeatedly format (#67892)
* Adjust constraints (#68437)
* update engine

Co-authored-by: xubaolin <xubaolin@oppo.com>
Co-authored-by: Michael Thomsen <mit@google.com>
This was referenced Oct 30, 2020
Closed
Closed
This was referenced Dec 11, 2020
Merged
Merged
Merged
Merged
This was referenced Feb 10, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirh amirh amirh left review comments

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove upper constraint on Flutter plugins and packages
4 participants
@mit-mit @fluttergithubbot @amirh @jonahwilliams
0