8000 Add fixes for nullOk changes by Piinks · Pull Request #74866 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add fixes for nullOk changes #74866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 28, 2021
Merged

Add fixes for nullOk changes #74866

merged 15 commits into from
Jan 28, 2021

Conversation

Piinks
Copy link
Contributor
@Piinks Piinks commented Jan 28, 2021 •
edited
Loading

This adds fixes for the nullOk changes made across the API. The changes these fix are expected to be widely breaking, so providing fixes will be immensely helpful to users. Proposing for cherry pick. cc @pcsosinski @gspencergoog

Migration guide lists and links to all associated changes: flutter/website#4921

Part of #74908

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. a: null-safety Support for Dart's null safety feature labels Jan 28, 2021
@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. labels Jan 28, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Jan 28, 2021
pcsosinski
pcsosinski reviewed Jan 28, 2021
View reviewed changes
packages/flutter/lib/fix_data.yaml Outdated
@@ -11,6 +11,98 @@
version: 1
transforms:

# Changes made in https://github.com/flutter/flutter/pull/69805.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#68905 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pcsosinski what is the question?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, typo! Thanks!

gspencergoog
gspencergoog approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor
@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@Piinks
Copy link
Contributor Author
Piinks commented Jan 28, 2021

@gspencergoog I fixed the rules that do not have maybes.

goderbauer
goderbauer approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member
@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite web_integration_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks merged commit a664731 into flutter:master Jan 28, 2021
christopherfujino pushed a commit to chris-forks/flutter that referenced this pull request Feb 3, 2021
@Piinks @christopherfujino
Add fixes for nullOk changes (flutter#74866)
205477e
@christopherfujino christopherfujino mentioned this pull request Feb 3, 2021
Merged
8 tasks
christopherfujino added a commit that referenced this pull request Feb 3, 2021
@christopherfujino @kenzieschmoll
@Piinks @jonahwilliams @goderbauer @bkonyi @jmagman
[flutter_releases] Flutter 1.26.0-17.2.pre Beta Framework Cherrypicks (…
79b49b9 
…#75303)

* Only show devtools deep links for render overflow errors (#74916)

* Add fixes for nullOk changes (#74866)

* [flutter_tools] delete old directories when unzipping ontop of them (#74818)

Fixes #74772

stale files from previous SDKs were getting left in the cache, confusing the analyzer.

* Make flutter create --smaple null-safe (#74844)

* Suppress 'Info: Compiling without sound null safety' message when building flutter_tools (#74740)

The CFE now logs to stdout by default when compiling a program which has
non-null-safe dependencies. Since flutter_tools has not yet migrated, we
need to suppress this message when compiling the tool.

Fixes #74366

* Split tools_tests subshards into separate shards to support sub-sub-sharding (#75033)

* Adopt tool_test shard builders (#75171)

* Adopt subshard naming convention in build_tests (#75179)

* Mark tool_integration_tests not flaky (#75273)

* roll flutter/plugins to ToT to fix analysis error

* update engine hash

Co-authored-by: Kenzie Schmoll <43759233+kenzieschmoll@users.noreply.github.com>
Co-authored-by: K
8000
ate Lovett <katelovett@google.com>
Co-authored-by: Jonah Williams <jonahwilliams@google.com>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: Ben Konyi <bkonyi@google.com>
Co-authored-by: Jenn Magder <magder@google.com>
@pcsosinski pcsosinski added this to the January Beta Release (1.26) milestone Feb 4, 2021
@rydmike rydmike mentioned this pull request Feb 13, 2021
Closed
@TimWhiting TimWhiting mentioned this pull request Feb 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcsosinski pcsosinski pcsosinski left review comments

@goderbauer goderbauer goderbauer approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
a: null-safety Support for Dart's null safety feature c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
January Beta Release (1.26)
Development

Successfully merging this pull request may close these issues.
5 participants
@Piinks @fluttergithubbot @goderbauer @gspencergoog @pcsosinski
0