Adopt tool_test shard builders #75171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d263474 to
d16495a
Compare
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
1ceffe6 to
14cff69
Compare
jmagman
commented
8000
Feb 1, 2021
| @@ -384,7 +398,15 @@ | |||
| "name": "Windows tool_tests", | |||
| "repo": "flutter", | |||
| "task_name": "win_tool_tests", | |||
| "enabled":true | |||
| "enabled":true, | |||
| "run_if":["dev/**", "packages/flutter_tools/**", "bin/**"] | |||
|
general and command subshards: https://ci.chromium.org/p/flutter/builders/try/Linux%20tool_tests/5703 |
christopherfujino
pushed a commit
to chris-forks/flutter
that referenced
this pull request
Feb 3, 2021
8 tasks
christopherfujino
added a commit
that referenced
this pull request
Feb 3, 2021
…#75303) * Only show devtools deep links for render overflow errors (#74916) * Add fixes for nullOk changes (#74866) * [flutter_tools] delete old directories when unzipping ontop of them (#74818) Fixes #74772 stale files from previous SDKs were getting left in the cache, confusing the analyzer. * Make flutter create --smaple null-safe (#74844) * Suppress 'Info: Compiling without sound null safety' message when building flutter_tools (#74740) The CFE now logs to stdout by default when compiling a program which has non-null-safe dependencies. Since flutter_tools has not yet migrated, we need to suppress this message when compiling the tool. Fixes #74366 * Split tools_tests subshards into separate shards to support sub-sub-sharding (#75033) * Adopt tool_test shard builders (#75171) * Adopt subshard naming convention in build_tests (#75179) * Mark tool_integration_tests not flaky (#75273) * roll flutter/plugins to ToT to fix analysis error * update engine hash Co-authored-by: Kenzie Schmoll <43759233+kenzieschmoll@users.noreply.github.com> Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Jonah Williams <jonahwilliams@google.com> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: Ben Konyi <bkonyi@google.com> Co-authored-by: Jenn Magder <magder@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt
tool_integration_testsbuilder from https://github.com/flutter/infra/pull/339 to test #75033.Example tool_integration_tests run:
Remove
tool_general_testsandtool_command_testsintroduced in #75033 since shards without subshards is evidently not supported (see https://github.com/flutter/infra/pull/340). Support these subshards intool_testsand simplify the subshard selecting logic in the runner.Fixes #75003