8000 Replace MockProcessManager with FakeProcessManager in cocoapods_test by jmagman · Pull Request #74956 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Replace MockProcessManager with FakeProcessManager in cocoapods_test #74956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2021
Merged

Replace MockProcessManager with FakeProcessManager in cocoapods_test #74956

merged 1 commit into from
Jan 29, 2021

Conversation

jmagman
Copy link
Member
@jmagman jmagman commented Jan 29, 2021
  • Replace MockProcessManager with FakeProcessManager.
  • Remove Pods repos dir is custom. This logic was removed in Update CocoaPods minimum version to 1.9 #71170 and evidently this test wasn't testing anything.
  • Replace try/catches in a few places with throwsToolExit.

Part of #71511

@jmagman jmagman added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jan 29, 2021
@jmagman jmagman self-assigned this Jan 29, 2021
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 29, 2021
@google-cla google-cla bot added the cla: yes label Jan 29, 2021
@jmagman jmagman requested a review from jonahwilliams January 29, 2021 22:13
jonahwilliams
jonahwilliams approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member
@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit dc30327 into flutter:master Jan 29, 2021
@jmagman jmagman deleted the cocoapods-test branch January 29, 2021 22:32
@jmagman jmagman added the c: tech-debt Technical debt, code quality, testing, etc. label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees

@jmagman jmagman

Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmagman @jonahwilliams
0