Update CocoaPods minimum version to 1.9 #71170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3f1d37 to
5da68fe
Compare
@christopherfujino this is true, right? |
|
Blocked by #69829 |
This was referenced Nov 30, 2020
|
I think I upgraded all the agents. Let's merge, I'll revert if something breaks post-submit. |
| messages.add(ValidationMessage(_userMessages.cocoaPodsVersion(await _cocoaPods.cocoaPodsVersionText))); | ||
| } else { | ||
| status = ValidationType.partial; | ||
| messages.add(ValidationMessage.error(_userMessages.cocoaPodsUninitialized(noCocoaPodsConsequence))); |
There was a problem hiding this comment.
can we also delete this user message?
There was a problem hiding this comment.
I missed that, good eye.
christopherfujino
approved these changes
Dec 15, 2020
5da68fe to
3817120
Compare
|
This change appears to be causing the issues seen in https://github.com/flutter/plugins/pull/3342/checks?check_run_id=1573661704. Is this considered a breaking change? |
|
@blasten it's not a breaking change, I just had to update plugin's CI to an updated version of CocoaPods. flutter/plugins#3347 |
cbracken
pushed a commit
to cbracken/flutter_recipes
that referenced
this pull request
Apr 6, 2021
Recipe support for flutter/flutter#71170 Mac iOS Engine Release: https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/magder_google.com/f9d3de6002d285a5ac0934913eca044f7224e0829064587bae923aa99cb74947/+/annotations?server=chromium-swarm.appspot.com Mac iOS Engine Profile: https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/magder_google.com/990946628fbbf37ea5039be27e9af59b9eadda0d5234659301ffb0c5e0010985/+/annotations?server=chromium-swarm.appspot.com Mac iOS Engine: https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/magder_google.com/70e4a2029437323cd8942ba5919a567078b6db72ec4803d1d72c9847f0cb164b/+/annotations?server=chromium-swarm.appspot.com ``` $ find . -print . ./Flutter.framework.zip ./gen_snapshot_arm64 ./Flutter.podspec ./Flutter.xcframework ./Flutter.xcframework/ios-armv7_arm64 ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/icudtl.dat ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Flutter ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Headers ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Headers/FlutterEngine.h ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Headers/FlutterChannels.h ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Headers/FlutterPlugin.h ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Headers/FlutterAppDelegate.h ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Headers/FlutterTexture.h ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Headers/FlutterPlatformViews.h ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Headers/FlutterHeadlessDartRunner.h ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Headers/FlutterCodecs.h ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Headers/Flutter.h ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Headers/FlutterViewController.h ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Headers/FlutterMacros.h ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Headers/FlutterDartProject.h ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Headers/FlutterPluginAppLifeCycleDelegate.h ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Headers/FlutterBinaryMessenger.h ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Headers/FlutterCallbackCache.h ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Modules ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Modules/module.modulemap ./Flutter.xcframework/ios-armv7_arm64/Flutter.framework/Info.plist ./Flutter.xcframework/ios-x86_64-simulator ./Flutter.xcframewor 76F1 k/ios-x86_64-simulator/Flutter.framework ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/icudtl.dat ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Flutter ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Headers ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Headers/FlutterEngine.h ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Headers/FlutterChannels.h ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Headers/FlutterPlugin.h ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Headers/FlutterAppDelegate.h ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Headers/FlutterTexture.h ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Headers/FlutterPlatformViews.h ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Headers/FlutterHeadlessDartRunner.h ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Headers/FlutterCodecs.h ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Headers/Flutter.h ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Headers/FlutterViewController.h ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Headers/FlutterMacros.h ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Headers/FlutterDartProject.h ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Headers/FlutterPluginAppLifeCycleDelegate.h ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Headers/FlutterBinaryMessenger.h ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Headers/FlutterCallbackCache.h ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Modules ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Modules/module.modulemap ./Flutter.xcframework/ios-x86_64-simulator/Flutter.framework/Info.plist ./Flutter.xcframework/Info.plist ./gen_snapshot_armv7 ``` Change-Id: I88da437311c16ffe4b3888fc3441b3be3f264841 Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/9020 Commit-Queue: Jenn Magder <magder@google.com> Reviewed-by: Keyong Han <keyonghan@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CocoaPods 1.9 introduced support for xcframeworks. It was released in February 2020.
isCocoaPodsInitializedwhich only mattered for versions < 1.8.Related Issues
#69809 is in 1.24.0-10.1.pre (currently dev and beta). This change will be in
flutter-1.25-candidate.*so the recommended minimum nudge should make it to stable before this harsher minimum requirement.