8000 Do not add CI build settings to macOS by jmagman · Pull Request #71860 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Do not add CI build settings to macOS #71860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2020
Merged

Do not add CI build settings to macOS #71860

merged 1 commit into from
Dec 7, 2020

Conversation

jmagman
Copy link
Member
@jmagman jmagman commented Dec 7, 2020

Description

#43553 added the ability to set Xcode build settings from environment variables so the devicelab could set up provisioning profiles. Using the same settings for iOS and macOS is causing macOS builds to fail. We think it is related to newer versions of CocoaPods incorrectly signing frameworks? (only executables like apps or extensions should be signed).

Related Issues

Workaround #71613

@jmagman jmagman added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Dec 7, 2020
@jmagman jmagman requested a review from yusufm December 7, 2020 19:26
@jmagman jmagman self-assigned this Dec 7, 2020
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 7, 2020
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Dec 7, 2020
@yusufm yusufm requested a review from godofredoc December 7, 2020 19:29
@jmagman jmagman merged commit 9a31c39 into flutter:master Dec 7, 2020
@jmagman jmagman deleted the mac-build-settings branch December 7, 2020 20:18
This was referenced Dec 7, 2020
Merged
Closed
Closed
@christopherfujino christopherfujino mentioned this pull request Dec 10, 2020
Merged
christopherfujino pushed a commit to chris-forks/flutter that referenced this pull request Jan 20, 2021
@jmagman @christopherfujino
Do not add CI build settings to macOS (flutter#71860)
aaba090
@christopherfujino christopherfujino mentioned this pull request Jan 20, 2021
Merged
christopherfujino added a commit that referenced this pull request Jan 22, 2021
@christopherfujino @jmagman
[flutter_releases] Flutter Stable 1.22.6 Framework Cherrypicks (#74355)
9b2d32b 
* Flutter clean Flutter.podspec (#72306)

* Do not add CI build settings to macOS (#71860)

* update engine revision to 2f0af3715217a0c2ada72c717d4ed9178d68f6ed

Co-authored-by: Jenn Magder <magder@google.com>
@jmagman jmagman mentioned this pull request May 7, 2021
Closed
@ndrianggar ndrianggar mentioned this pull request Jul 12, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yusufm yusufm yusufm approved these changes

@godofredoc godofredoc godofredoc approved these changes

Assignees

@jmagman jmagman

Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmagman @yusufm @godofredoc
0