8000 Flutter clean Flutter.podspec by jmagman · Pull Request #72306 · flutter/flutter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Flutter clean Flutter.podspec #72306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2020
Merged

Flutter clean Flutter.podspec #72306

merged 1 commit into from
Dec 15, 2020

Conversation

jmagman
Copy link
Member
@jmagman jmagman commented Dec 14, 2020

Description

#70224 (on master/dev) purposely writes a bogus file to ios/Flutter/Flutter.podspec because the CocoaPods linking logic was moved into the flutter tool. However, when users switch back to beta/stable, that bogus podspec is still present, but the flutter tool linking logic has been reverted.

At the moment this change isn't "necessary" on master, but it's a good idea in case we ever change it again.

Related Issues

Once cherry-picked to stable/release, will resolve #70895 by running flutter clean.

Tests

clean_test

@jmagman jmagman added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 14, 2020
@jmagman jmagman self-assigned this Dec 14, 2020
@google-cla google-cla bot added the cla: yes label Dec 14, 2020
@jmagman jmagman mentioned this pull request Dec 14, 2020
Closed
@fluttergithubbot fluttergithubbot merged commit 617c57b into flutter:master Dec 15, 2020
@jmagman jmagman deleted the clean-podspec branch December 15, 2020 18:03
christopherfujino added a commit to chris-forks/flutter that referenced this pull request Jan 20, 2021
@christopherfujino
Flutter clean Flutter.podspec (flutter#72306)
e5b8bbb
@christopherfujino christopherfujino mentioned this pull request Jan 22, 2021
Merged
christopherfujino added a commit that referenced this pull request Jan 22, 2021
@christopherfujino @jmagman
[flutter_releases] Flutter Stable 1.22.6 Framework Cherrypicks (#74355)
9b2d32b 
* Flutter clean Flutter.podspec (#72306)

* Do not add CI build settings to macOS (#71860)

* update engine revision to 2f0af3715217a0c2ada72c717d4ed9178d68f6ed

Co-authored-by: Jenn Magder <magder@google.com>
@ndrianggar ndrianggar mentioned this pull request Jul 12, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

@jmagman jmagman

Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fatal error: 'Flutter\Flutter.h' file not found #import <Flutter\Flutter.h> - IOS
3 participants
@jmagman @zanderso @fluttergithubbot
0