-
Notifications
You must be signed in to change notification settings - Fork 4
Revise input fields and metadata I/O #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- For single-sample input: sample_unique_id, sample_display_name - For multi-sample input: sample_in_metadata Unpack these in the 'laava' named workflow so that single- and multi-sample inputs are equivalent in the downstream processes.
prepare_annotation: Allow nonstandard reference "source type" names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can align on the comments and address them on the next release.
Terminal Repeat (ITR) regions (see itr_label_1 and itr_label_2 below) or, as a | ||
legacy mode, one region with the label 'vector', spanning both ITRs (inclusive). | ||
- May also include additional labeled regions, e.g. for promoter and CDS regions; | ||
these will be ignored and will not affect the output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should think about adding a minimal BED file information, in the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What additional information would you like to see here? An explanation of the BED format?
workflows/laava/workflow.json
Outdated
"format": "text", | ||
< 8000 /td> | "hidden": false, | |
"required": false, | ||
"default": "ITR", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep default to ITR for both first and second ITR.
What is the rational to have first and second, rather than previously left and right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From looking at a circular diagram in SnapGene, users might confuse or swap the order of the ITRs in the exported BED/Genbank file. This way, "ITR-R" followed by "ITR-L" will work, even if swapped. As a side effect, entering "ITR" for both itr_label_1 and itr_label_2 works the same as leaving itr_label_2 blank.
First step in revising the classification and output TSV schema for v3.0 -- new input fields.