8000 Revise input fields and metadata I/O by etal · Pull Request #50 · formbio/laava · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revise input fields and metadata I/O #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 6, 2024
Merged

Revise input fields and metadata I/O #50

merged 12 commits into from
Aug 6, 2024

Conversation

etal
Copy link
Contributor
@etal etal commented Jul 13, 2024

First step in revising the classification and output TSV schema for v3.0 -- new input fields.

@etal etal requested a review from alphabdiallo July 15, 2024 17:20
- For single-sample input: sample_unique_id, sample_display_name
- For multi-sample input: sample_in_metadata

Unpack these in the 'laava' named workflow so that single- and
multi-sample inputs are equivalent in the downstream processes.
@etal etal changed the title Revise classification and output TSV schema Revise input fields and metadata I/O Jul 31, 2024
@etal etal marked this pull request as ready for review July 31, 2024 05:43
@etal etal requested a review from Magdoll July 31, 2024 23:39
Copy link
Contributor
@alphabdiallo alphabdiallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can align on the comments and address them on the next release.

Terminal Repeat (ITR) regions (see itr_label_1 and itr_label_2 below) or, as a
legacy mode, one region with the label 'vector', spanning both ITRs (inclusive).
- May also include additional labeled regions, e.g. for promoter and CDS regions;
these will be ignored and will not affect the output.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should think about adding a minimal BED file information, in the documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What additional information would you like to see here? An explanation of the BED format?

"format": "text",
< 8000 /td> "hidden": false,
"required": false,
"default": "ITR",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep default to ITR for both first and second ITR.
What is the rational to have first and second, rather than previously left and right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From looking at a circular diagram in SnapGene, users might confuse or swap the order of the ITRs in the exported BED/Genbank file. This way, "ITR-R" followed by "ITR-L" will work, even if swapped. As a side effect, entering "ITR" for both itr_label_1 and itr_label_2 works the same as leaving itr_label_2 blank.

@etal etal merged commit ab844ef into main Aug 6, 2024
3 checks passed
@etal etal deleted the schema3 branch August 6, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0