8000 perf: speedup `frappe.call` by ~8x by ankush · Pull Request #28866 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

perf: speedup frappe.call by ~8x #28866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2024
Merged

perf: speedup frappe.call by ~8x #28866

merged 1 commit into from
Dec 23, 2024

Conversation

ankush
Copy link
Member
@ankush ankush commented Dec 23, 2024

Function signatures can't change during the lifetime of the process.

Before: 8.81us
After: 1.1us

Benchmarks in caffeine repo

partly frappe/caffeine#18

@ankush ankush enabled auto-merge (squash) December 23, 2024 06:06
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Dec 23, 2024
@ankush ankush disabled auto-merge December 23, 2024 06:18
Before: 8.81us
After: 1.1us

Benchmarks in caffeine repo
@ankush ankush enabled auto-merge (squash) December 23, 2024 06:21
@ankush ankush merged commit 197a49c into frappe:develop Dec 23, 2024
25 checks passed
@ankush ankush deleted the perf/call branch December 23, 2024 06:41
akhilnarang added a commit to netchampfaris/frappe that referenced this pull request Dec 24, 2024
…-message

* upstream/develop: (1373 commits)
  perf: cache dynamic links map in Redis (frappe#28878)
  fix: Never query `flag_print_sql` in `developer_mode=0` (frappe#28884)
  fix(restore): remove MariaDB view security definers
  fix: sanitize user input during setup wizard
  feat(sanitize_column): improve check
  refactor: make optimizations.py private entirely (frappe#28872)
  fix(site_cache): site cache thread safety (frappe#28870)
  chore(printview): change error message
  perf: speedup `frappe.call` by ~8x (frappe#28866)
  test: reduce noise in test output (frappe#28862)
  chore: spelling_invalid_values (frappe#28858)
  fix: Remove misleading os.O_NONBLOCK flag (frappe#28859)
  fix: string replacement in error logger
  perf(gthread): Pin web workers to a single core (frappe#28854)
  fix: MariaDBDatabase.get_tables() should not query the entire database schema (frappe#28846)
  fix: add strings and fields to translation
  fix: typo in test controller boilerplate
  perf: faster add_to_date (frappe#28843)
  perf(version): Make get_versions fast for autoincrement doctypes (frappe#28847)
  refactor: log in monitor as well
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2025
@ankush ankush added backport version-15-hotfix Backport the PR to v15 and removed add-test-cases Add test case to validate fix or enhancement labels Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0