fix: Never query flag_print_sql in developer_mode=0
#28884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unnecessary overhead and need to disable this everytime I want to get realistic performance numbers out. All the performance affecting toggles should be directly controlled by just `developer_mode` alone.
akhilnarang
added a commit
to netchampfaris/frappe
that referenced
this pull request
Dec 24, 2024
…-message * upstream/develop: (1373 commits) perf: cache dynamic links map in Redis (frappe#28878) fix: Never query `flag_print_sql` in `developer_mode=0` (frappe#28884) fix(restore): remove MariaDB view security definers fix: sanitize user input during setup wizard feat(sanitize_column): improve check refactor: make optimizations.py private entirely (frappe#28872) fix(site_cache): site cache thread safety (frappe#28870) chore(printview): change error message perf: speedup `frappe.call` by ~8x (frappe#28866) test: reduce noise in test output (frappe#28862) chore: spelling_invalid_values (frappe#28858) fix: Remove misleading os.O_NONBLOCK flag (frappe#28859) fix: string replacement in error logger perf(gthread): Pin web workers to a single core (frappe#28854) fix: MariaDBDatabase.get_tables() should not query the entire database schema (frappe#28846) fix: add strings and fields to translation fix: typo in test controller boilerplate perf: faster add_to_date (frappe#28843) perf(version): Make get_versions fast for autoincrement doctypes (frappe#28847) refactor: log in monitor as well ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unnecessary overhead and need to disable this everytime I want to get
realistic performance numbers out.
All the performance affecting toggles should be directly controlled by
just
developer_modealone.