perf: split maintenance tasks into separate queue (backport #32413) #32461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Maintenance queues for scheduled jobs * refactor: Move jobs to maintenance queues * test: update tests (cherry picked from commit e26ba5d) # Conflicts: # frappe/core/doctype/scheduled_job_type/scheduled_job_type.json # frappe/core/doctype/scheduled_job_type/scheduled_job_type.py # frappe/hooks.py
|
Cherry-pick of e26ba5d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 13, 2025
## [15.68.1](v15.68.0...v15.68.1) (2025-05-13) ### Bug Fixes * 'not set' equivalence in query conditions (backport [#28015](#28015)) ([#32451](#32451)) ([273bb79](273bb79)) * add deprecation warning for social module energy points ([6764a9e](6764a9e)) * **apps:** don't skip app if no permission hook (backport [#32492](#32492)) ([#32505](#32505)) ([af3f337](af3f337)) * change limit to 100k ([#32419](#32419)) ([#32434](#32434)) ([1faeb91](1faeb91)) * conflicts in yarn.lock ([7f724ad](7f724ad)) * correct yarn.lock ([f1ff8ed](f1ff8ed)) * **db_query:** double-escaped value ([#32376](#32376)) ([#32447](#32447)) ([4e3a1f4](4e3a1f4)) * don't allow attaching an file invalid url ([4008fcf](4008fcf)) * layout for file uploader ([#32476](#32476)) ([7ae3b3e](7ae3b3e)) * remove ui warnings for now ([6721178](6721178)) * resolve conflicts in yarn.lock ([d985c3a](d985c3a)) * revert python changes and do via js ([7082a04](7082a04)) * rq worker count (backport [#31800](#31800)) ([#32491](#32491)) ([1884b75](1884b75)) * **TextEditor:** table actions as handle to quills toolbar ([432626e](432626e)) * translation backport command (CLI) ([#32485](#32485)) ([0237077](0237077)) * update email template hex code according to espresso (backport [#32401](#32401)) ([#32490](#32490)) ([00f91fd](00f91fd)) ### Performance Improvements * split maintenance tasks into separate queue (backport [#32413](#32413)) ([#32461](#32461)) ([844314d](844314d)) * transform ifnull into two conditions (backport [#32377](#32377)) ([#32457](#32457)) ([1d49173](1d49173))
A683
|
🎉 This PR is included in version 15.68.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32270
TL;DR: I've moved some (almost 80%) of hourly/daily jobs that don't have strict wall clock frequency requirements. They'll now execute at random times but with same frequency.
This isn't truly "random", it's quite deterministic based on site name. Site's name is hashed to find out roughly when all of its jobs should run. This still ensures that in large multi tenant deploys all the jobs will be sufficiently spaced out across entire hour.
This is an automatic backport of pull request #32413 done by [Mergify](https://mergify.com).