fix: change limit to 100k #32419
fix: change limit to 100k #32419
Conversation
(cherry picked from commit b34b6d7)
(cherry picked from commit b34b6d7)
|
Related to support ticket: 37774 ?? |
## [14.96.3](v14.96.2...v14.96.3) (2025-05-13) ### Bug Fixes * 'not set' equivalence in query conditions (backport [#28015](#28015)) ([#32450](#32450)) ([8cf37ef](8cf37ef)) * change limit to 100k ([#32419](#32419)) ([#32433](#32433)) ([91d2148](91d2148)) * **db_query:** double-escaped value (backport [#32376](#32376)) ([#32446](#32446)) ([abb7098](abb7098))
## [15.68.1](v15.68.0...v15.68.1) (2025-05-13) ### Bug Fixes * 'not set' equivalence in query conditions (backport [#28015](#28015)) ([#32451](#32451)) ([273bb79](273bb79)) * add deprecation warning for social module energy points ([6764a9e](6764a9e)) * **apps:** don't skip app if no permission hook (backport [#32492](#32492)) ([#32505](#32505)) ([af3f337](af3f337)) * change limit to 100k ([#32419](#32419)) ([#32434](#32434)) ([1faeb91](1faeb91)) * conflicts in yarn.lock ([7f724ad](7f724ad)) * correct yarn.lock ([f1ff8ed](f1ff8ed)) * **db_query:** double-escaped value ([#32376](#32376)) ([#32447](#32447)) ([4e3a1f4](4e3a1f4)) * don't allow attaching an file invalid url ([4008fcf](4008fcf)) * layout for file uploader ([#32476](#32476)) ([7ae3b3e](7ae3b3e)) * remove ui warnings for now ([6721178](6721178)) * resolve conflicts in yarn.lock ([d985c3a](d985c3a)) * revert python changes and do via js ([7082a04](7082a04)) * rq worker count (backport [#31800](#31800)) ([#32491](#32491)) ([1884b75](1884b75)) * **TextEditor:** table actions as handle to quills toolbar ([432626e](432626e)) * translation backport command (CLI) ([#32485](#32485)) ([0237077](0237077)) * update email template hex code according to espresso (backport [#32401](#32401)) ([#32490](#32490)) ([00f91fd](00f91fd)) ### Performance Improvements * split maintenance tasks into separate queue (backport [#32413](#32413)) ([#32461](#32461)) ([844314d](844314d)) * transform ifnull into two conditions (backport [#32377](#32377)) ([#32457](#32457)) ([1d49173](1d49173))
|
@ankush this contradicts Kindly help resolve or change design asap, as it will affect all enterprise users or any instance with good data volume & completely unacceptable solution to download to excel and view it. |
|
@ashish-greycube this is hard to fix without fixing the underlying problem: frappe/datatable#216 Currently, those with resource-constrained machines can't do anything if the report fails to render. Falling back to export is at least better than not being able to do anything. Few possible fixes @sokumon @iamejaaz:
|
|
|
Is >100k rows even usable? I have a fairly recent machine with top-end Ryzen chip and 16GB RAM, I can render 1M rows, but it's hardly usable after rendering. It lags everywhere and filters etc don't work. I think for data this large, there won't be any option to render it in the browser beyond a point. The best we can do is pagination, which will again restrict a lot of other features. I made a small fix here that will allow increasing the limit to maybe 200K: frappe/datatable#217
Yeah, it should work fine. Individual vouchers rarely have even >100 lines.
We can't, at least not by default... because those with weaker machines won't even be able to view the report or export it. The best we can do right now is make it configurable. @sokumon can you make this configurable? System settings > reporting, add a new config for max report rows. |
|
thanks for the clarifications, the insights and the quick fix to allow it upto 200k.
use case : when users have to search a specific record or bunch of records ( specially accounts users, in a Financial year) , they tend to load everything without much of filtering and via scrolling they try to search.. continuously changing the filters to narrow the results to keep it less than 100k leads to a major UX issue and feels like being handcuffed ! |
No description provided.