8000 Runtime improvement designwnd by Mr-Twave · Pull Request #5213 · freeorion/freeorion · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Runtime improvement designwnd #5213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Runtime improvement designwnd #5213

wants to merge 2 commits into from

Conversation

Mr-Twave
Copy link
Contributor

Runtime improvements. This is more of an experiment.

  1. SlotControl::SetPart UI Component Reuse
    Optimize the SlotControl::SetPart method to reuse existing PartControl objects when possible instead of recreating them for every part change.

  2. Add PartControl::UpdatePart Method
    Add a new method to allow updating a part in-place:
    Location: In the PartControl class in DesignWnd.cpp, after the CompleteConstruction method

  • Added declaration in the class definition

  1. String Optimization in GetCleanDesignDump

  2. Type-Safe Enums for Boolean Parameters

enum class EmitSignal { No, Yes };
enum class ChangeAllSimilar { No, Yes };

  1. Replace std::list with std::vector in DisplayedShipDesignManager
    Location: In DisplayedShipDesignManager class definition

  2. Optimize MoveBefore Method for Vector
    Location: DisplayedShipDesignManager::MoveBefore implementation

  3. Optimize RefreshIncompleteDesign Method
    (yet to be done)

Mr-Twave added 2 commits April 16, 2025 14:30
@Mr-Twave
Update DesignWnd.cpp
9e302f0 
runtime improvments
@Mr-Twave
Update DesignWnd.h
7a603f7 
runtime improvements
@geoffthemedio
Copy link
Member

Please use more detail commit messages than "runtime improvements". You already wrote more for the pull request test...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mr-Twave @geoffthemedio
0