Add a user-defined passkey name to the passkey data #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kelvin Chappell <1722550+kelvin-chappell@users.noreply.github.com>
…mission Co-authored-by: Kelvin Chappell <1722550+kelvin-chappell@users.noreply.github.com>
Co-authored-by: Kelvin Chappell <1722550+kelvin-chappell@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability for users to assign a custom name to their passkeys during registration and uses that name to list passkeys on the account page.
- Introduces a new modal prompt (using Materialize CSS) to retrieve the passkey name from the user.
- Wraps registration and authentication flows in try-catch blocks for improved error handling.
- Refactors form submission by dynamically creating a form with the necessary fields, including the passkey name.
Files not reviewed (8)
- app/aws/PasskeyChallengeDB.scala: Language not supported
- app/aws/PasskeyDB.scala: Language not supported
- app/controllers/PasskeyAuthFilter.scala: Language not supported
- app/controllers/PasskeyController.scala: Language not supported
- app/logic/Passkey.scala: Language not supported
- app/models/models.scala: Language not supported
- app/views/userAccount.scala.html: Language not supported
- test/logic/PasskeyTest.scala: Language not supported
kelvin-chappell
commented
May 12, 2025
8000
|
|
||
| // Clear error when typing | ||
| input.addEventListener('input', () => { | ||
| if (input.value.trim()) { |
There was a problem hiding this comment.
Needs more input validation - eg restrict to alphanumeric etc.
tjsilver
approved these changes
May 12, 2025
|
Can successfully register a new passkey in Prod and see its name: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
This adds a mechanism to the frontend to set a passkey name during the registration process. The name is added to the data stored in the Dynamo passkeys table. This change also uses the names to list passkeys on the user account page.
What is the value of this change and how do we measure success?
Users are allowed up to two passkeys so this change enables them to identify the passkeys they have already registered. In the future it will allow them to choose which one to delete if they want to.
Co-authored-by: @tjsilver