feat: add registration timestamp to passkey data #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (5)
- app/aws/PasskeyDB.scala: Language not supported
- app/controllers/PasskeyController.scala: Language not supported
- app/models/Passkey.scala: Language not supported
- app/views/userAccount.scala.html: Language not supported
- test/logic/PasskeyTest.scala: Language not supported
7fb4252 to
df9180d
Compare
There was a problem hiding this comment.
Copilot reviewed 1 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (5)
- app/aws/PasskeyDB.scala: Language not supported
- app/controllers/PasskeyController.scala: Language not supported
- app/models/Passkey.scala: Language not supported
- app/views/userAccount.scala.html: Language not supported
- test/logic/PasskeyTest.scala: Language not supported
tjsilver
reviewed
May 12, 2025
There was a problem hiding this comment.
Looks like it's just whitespace changes in this file?
There was a problem hiding this comment.
Yes there are no changes on the frontend. It's all in the template and serverside as we generate the timestamp there.
tjsilver
reviewed
May 13, 2025
|
Works in Prod: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
It adds the time that a passkey was created and registered in Janus to the database and shows it in the UI.
What is the value of this change and how do we measure success?
We can see when a passkey was created and use this data for troubleshooting or for sorting and filtering.
Any additional notes?
See also #566