Enable e2e tests using emulators for cloud providers [ aws, gcp, azure ] #743
Conversation
|
@anveshreddy18 You need rebase this pull request with latest master branch. Please check. |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
95246b4 to
546dbb5
Compare
There was a problem hiding this comment.
@anveshreddy18 thank you very much for making the requested changes! I still have a few suggestions for easing the consumption of the new make targets and tests. PTAL and address them, thanks!
Makefile
Outdated
| .PHONY: pr-test-e2e | ||
| pr-test-e2e: | ||
| ./hack/ci-e2e-kind.sh aws | ||
|
|
||
| .PHONY: merge-test-e2e | ||
| merge-test-e2e: | ||
| ./hack/ci-e2e-kind.sh aws,gcp,azure |
There was a problem hiding this comment.
When we run in prow jobs, I foresee that we will have one prow job config per provider, like ci-e2e-kind-aws, ci-e2e-kind-local, etc, so that we can easily run the jobs in parallel, like the e2e tests that are run in gardener/gardener. While ci-e2e-kind-local is run against every PR, we can selectively run the other aws,gcp,azure tests based on file selector rules. For instance, if you check the prow docs, there's a field called run_if_changed, which tells the test to run if certain files have changes in the PR, as per a given regex. So for any aws-related files, it can automatically run ci-e2e-kind-aws, as an example. And if at all the PR changes something which could affect AWS provider but not have any specific changes in aws-related files, then we can simply trigger the test manually by commenting /test ci-e2e-kind-aws. Unfortunately prow doesn't allow label-based triggering of jobs, unlike concourse.
Enabling prow jobs would be the next logical step in the overall etcd-backup-restore e2e tests story.
546dbb5 to
c1ef2a7
Compare
Address review comments
c1ef2a7 to
46184a0
Compare
There was a problem hiding this comment.
@anveshreddy18 thank you for making all the requested changes. LGTM!
/lgtm
What this PR does / why we need it:
This PR revives the currently non functional e2e tests ( previously
integrationclustertests ) and enable them to run with real infra andemulatorsof 3 major cloud providers i.e AWS, GCP, AZURE. The reason for using emulators is to reduce the cost of using real infra every time a PR is raised because with the enablement of e2e tests with this PR, these tests will be run as prow job for every PR.To run these e2e tests locally, just need to do
make ci-e2e-kind PROVIDERS="aws,gcp,azure". The provider list can be edited to run tests with only those specific providers.This PR also upgrades the helm version from
k8.io/helm/v2tohelm.sh/helm/v3, with this changes a lot of indirect dependency graph, as a result, thego.modandvendor/changes.Which issue(s) this PR fixes:
Fixes #722
Special notes for your reviewer:
Release note: