8000 Changes in e2e tests setup required for running them in prow job environment by anveshreddy18 · Pull Request #862 · gardener/etcd-backup-restore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Changes in e2e tests setup required for running them in prow job environment #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 9, 2025
Merged

Changes in e2e tests setup required for running them in prow job environment #862

merged 5 commits into from
Apr 9, 2025

Conversation

anveshreddy18
Copy link
Contributor

How to categorize this PR?

/area testing
/kind test

What this PR does / why we need it:

The PR #743 restored the e2e tests and made them run with cloud providers(real infra & their emulators), to make that happen it installs the provider CLIs such as awscli, az and gcloud to interact with both real providers and emulators. The current code uses pip3 to install these CLI tools but we plan to run these tests in prow environment where they run inside a Debian linux container where pip3 is not present by default. So the PR makes changes to install these tools using apt pkg manager which is native to Debian environments.

This PR also fixes a failing e2e test case where the pgrep command to get the PID of the etcd-wrapper process is not working as intended, changed it to use combination of ps, grep and awk through piping.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Updated e2e test setup to install provider CLIs using `apt` package manager and fixed a failing test case involving `etcd-wrapper` process PID retrieval.

@anveshreddy18 anveshreddy18 requested a review from a team as a code owner April 7, 2025 08:28
@gardener-robot gardener-robot added needs/review Needs review area/testing Testing related kind/test Test size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Apr 7, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 7, 2025
@anveshreddy18 anveshreddy18 self-assigned this Apr 7, 2025
@anveshreddy18 anveshreddy18 requested a review from Copilot April 7, 2025 11:57
Copilot
Copilot AI reviewed Apr 7, 2025
View reviewed changes
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • hack/e2e-test/run-e2e-test.sh: Language not supported

@renormalize renormalize added this to the v0.36.0 milestone Apr 7, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 8, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 8, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 8, 2025
ishan16696
ishan16696 reviewed Apr 9, 2025
View reviewed changes
Copy link
Member
@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just few doubts:

@anveshreddy18 anveshreddy18 added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Apr 9, 2025
@anveshreddy18
Copy link
Contributor Author

/test pull-etcd-backup-restore-e2e-kind

@anveshreddy18 anveshreddy18 removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Apr 9, 2025
@anveshreddy18 anveshreddy18 merged commit 5b6bba2 into gardener:master Apr 9, 2025
10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 9, 2025
ishan16696 pushed a commit to ishan16696/etcd-backup-restore that referenced this pull request Apr 24, 2025
@anveshreddy18 @ishan16696
Changes in e2e tests setup required for running them in prow job envi…
630ed26 
…ronment (gardener#862)

* use apt instead of pip to install awscli
* install whole gcloud sdk instead of just gsutil
* fix a failing test
* fix another failing test after rebase on master
* improve error handling when failure in creating buckets
@renormalize renormalize mentioned this pull request Apr 24, 2025
Merged
ishan16696 added a commit that referenced this pull request Apr 24, 2025
@ishan16696 @anveshreddy18
Support non-HA autonomous clusters (#764) (#870)
9aaa3f0 
* Support non-HA autonomous clusters (#764)

* Changes in e2e tests setup required for running them in prow job environment (#862)

* use apt instead of pip to install awscli
* install whole gcloud sdk instead of just gsutil
* fix a failing test
* fix another failing test after rebase on master
* improve error handling when failure in creating buckets

---------

Co-authored-by: Anvesh Reddy Pinnapureddy <anvesh.reddy.pinnapureddy@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishan16696 ishan16696 ishan16696 approved these changes

Copilot code review Copilot Copilot left review comments

Assignees

@anveshreddy18 anveshreddy18

Labels
area/testing Testing related kind/test Test needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.36.0
Development

Successfully merging this pull request may close these issues.
7 participants
@anveshreddy18 @ishan16696 @gardener-robot-ci-1 @renormalize @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot
0