8000 Support non-HA autonomous clusters by ishan16696 · Pull Request #764 · gardener/etcd-backup-restore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support non-HA autonomous clusters #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

Support non-HA autonomous clusters #764

merged 1 commit into from
Apr 24, 2025

Conversation

ishan16696
Copy link
Member
@ishan16696 ishan16696 commented Aug 26, 2024 •
edited by shreyas-s-rao
Loading

What this PR does / why we need it:
This PR moves the creation of kubernetes clientSet for multi-node cluster only.
kubernetes clientSet won't be created for nonHA etcd cluster.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Support non-HA autonomous clusters by skipping creation of Kubernetes clientset.
⚠️ To completely prevent the creation of the Kubernetes `clientSet` in the non-HA etcd-backup-restore, please also set the following CLI flags to `false`: `--enable-member-lease-renewal` and `--enable-snapshot-lease-renewal`.

@ishan16696 ishan16696 requested a review from a team as a code owner August 26, 2024 11:08
@gardener-robot gardener-robot added the needs/review Needs review label Aug 26, 2024
@ishan16696 ishan16696 added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Aug 26, 2024
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Aug 26, 2024
@ishan16696 ishan16696 marked this pull request as draft August 26, 2024 11:08
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 26, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 26, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 10, 2025
@ishan16696 ishan16696 removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Apr 10, 2025
@ishan16696 ishan16696 marked this pull request as ready for review April 10, 2025 17:48
@ishan16696 ishan16696 changed the title WIP: some fixes for non-HA autonomous cluster. small fix to run non-HA autonomous cluster. Apr 10, 2025
@ishan16696 ishan16696 self-assigned this Apr 14, 2025
@shreyas-s-rao shreyas-s-rao self-assigned this Apr 14, 2025
@shreyas-s-rao shreyas-s-rao mentioned this pull request Apr 15, 2025
Open
8 tasks
shreyas-s-rao
shreyas-s-rao requested changes Apr 21, 2025
View reviewed changes
Copy link
Collaborator
@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishan16696 just one comment. PTAL.

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Apr 21, 2025
@shreyas-s-rao shreyas-s-rao mentioned this pull request Apr 21, 2025
Open
29 tasks
shreyas-s-rao
shreyas-s-rao approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator
@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Apr 24, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 24, 2025
@shreyas-s-rao shreyas-s-rao changed the title small fix to run non-HA autonomous cluster. Support non-HA autonomous clusters Apr 24, 2025
@shreyas-s-rao shreyas-s-rao merged commit a0d7902 into gardener:master Apr 24, 2025
10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 24, 2025
@shreyas-s-rao shreyas-s-rao added this to the v0.36.0 milestone Apr 24, 2025
@ishan16696 ishan16696 deleted the autonomous branch April 24, 2025 10:32
ishan16696 added a commit to ishan16696/etcd-backup-restore that referenced this pull request Apr 24, 2025
@ishan16696
Support non-HA autonomous clusters (gardener#764)
bf9f3a8
@ishan16696 ishan16696 mentioned this pull request Apr 24, 2025
Merged
ishan16696 added a commit that referenced this pull request Apr 24, 2025
@ishan16696 @anveshreddy18
Support non-HA autonomous clusters (#764) (#870)
9aaa3f0 
* Support non-HA autonomous clusters (#764)

* Changes in e2e tests setup required for running them in prow job environment (#862)

* use apt instead of pip to install awscli
* install whole gcloud sdk instead of just gsutil
* fix a failing test
* fix another failing test after rebase on master
* improve error handling when failure in creating buckets

---------

Co-authored-by: Anvesh Reddy Pinnapureddy <anvesh.reddy.pinnapureddy@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

Assignees

@shreyas-s-rao shreyas-s-rao

@ishan16696 ishan16696

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.36.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ishan16696 @shreyas-s-rao @gardene 34EC r-robot-ci-1 @gardener-robot-ci-2 @gardener-robot
0