Add FlatRiemannianMetric and fix EuclideanMetric inheritance #1946
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1946 +/- ##
==========================================
- Coverage 91.51% 91.34% -0.16%
==========================================
Files 149 146 -3
Lines 13624 13450 -174
==========================================
- Hits 12466 12284 -182
- Misses 1158 1166 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Could the distinction EuclideanMetric and StandardEuclideanMetric be hidden for the user? As a user, if I want the standard euclidean metric, I will search the library for EuclideanMetric, see that there is something, and try to use that.
Could one of them be private, and only a single class EuclideanMetric be accessible, such that this class dispatches between the Standard and the Matrix euclidean metrics?
At the very least the docstrings should explain the difference between the two.
fee3b52 to
7c912e8
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
7c912e8 to
f7e5b45
Compare
f7e5b45 to
f6b3ca2
Compare
|
@ninamiolane, I'm using |
This PR splits
EuclideanMetricintoFlatRiemannianMetricand the usualEuclideanMetric. The first is a flat metric whosemetric_matrixcan be different from the usual Euclidean metric. The second assumes the metric matrix isgs.eye(dim).See next PRs for further justification for this split.