Add new flat Matrices metrics #1947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1947 +/- ##
==========================================
+ Coverage 91.37% 91.48% +0.12%
==========================================
Files 146 143 -3
Lines 13450 13009 -441
==========================================
- Hits 12288 11900 -388
+ Misses 1162 1109 -53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
822c4eb to
ab7dd1b
Compare
ninamiolane
requested changes
Feb 8, 2024
ab7dd1b to
9ca6b17
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
4c1ec0c to
d3fdf88
Compare
|
@ninamiolane, docstrings updated. Could you please review now? |
d3fdf88 to
53ebf0c
Compare
53ebf0c to
e645e47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #1946 to add new metric matrices for
Matrices(and other matrix vector spaces). Explicitly, we addMatricesDiagMetric. With the addition of diffeomorphisms to theEuclideanSpace, we implicitly add the ability to easily implement aPullbackDiffeoMetricfrom anEuclideanspace equipped with a non-standardEuclideanMetric.Next PR will show application of these concepts.
NB: merging this PR before #1946 also merges #1946.