cmake.eclass: Add src_install() check for CMake-4-incompatible modules #1047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgorny
reviewed
Jun 13, 2025
eclass/cmake.eclass
Outdated
| # Internal function for detecting occurrence of lower-than-specified | ||
| # <lt-version> in cmake_minimum_required of a given CMake file <path>. | ||
| # Returns 1 if the regex matched (a lower-than-specified version found). | ||
| _cmake_minreqver-detect() { |
There was a problem hiding this comment.
I would name it "_cmake_minreqver_lt" or alike, to make it clear it detects "lower than" version. Or just make it "_cmake_minreqver_test" and let the caller specify the operator.
There was a problem hiding this comment.
@mgorny we don't ever need to look in the other direction, so _cmake_minreqver_lt would be fine.
and then reverse the return value logic, so success follows the wording of the function name, I guess
Allows to split detection/eqawarn and applying cmakearg over different phases. Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
ionenwks
reviewed
Jun 13, 2025
thesamesam
approved these changes
Jun 13, 2025
- _cmake_minverreq-lt(): New function for reusability of regex - Optimise #1: Reuse existing loop over CMakeLists.txt files - Optimise gentoo#2: If _CMAKE_MINREQVER_UNSUPPORTED is already set, then no further run of _cmake_minverreq-lt is necessary since we currently throw away the info on affected files - Relegate "CMake 4 detected; ..." to be a non-QA Notice, it is just an addendum Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Thanks-to: Ionen Wolkens <ionen@gentoo.org> Closes: https://bugs.gentoo.org/957990 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
See examples: https://bugs.gentoo.org/953075 https://bugs.gentoo.org/957670 https://bugs.gentoo.org/957671 https://bugs.gentoo.org/957803 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.