[core] move fromCompletionStage from Fiber to Async #1195
Merged
+38
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hearnadam
reviewed
May 17, 2025
| @@ -3,17 +3,14 @@ package kyo.internal | |||
| import java.util.concurrent.CompletionStage | |||
| import kyo.* | |||
|
|
|||
| trait FiberPlatformSpecific: | |||
| trait AsyncPlatformSpecific: | |||
| def fromCompletionStage[A](cs: CompletionStage[A])(using Frame): A < Async = | |||
There was a problem hiding this comment.
I think we can alias this to fromFuture as well. It should typecheck as an overload (to Scala's future).
hearnadam
approved these changes
May 17, 2025
fwbrasil
commented
May 21, 2025
| @@ -1028,7 +1028,7 @@ class ChannelTest extends Test: | |||
| latch.await.andThen(channel.close) | |||
| ) | |||
| _ <- latch.release | |||
| _ <- channel.drain | |||
| _ <- Abort.run(channel.drain) | |||
There was a problem hiding this comment.
@steinybot This might fix the test flakiness. it seems expected that the channel can be closed at this point since it's a race with closeFiber
fwbrasil
added a commit
that referenced
this pull request
May 22, 2025
### Problem Following the rationale of #1195, `Channel` and `Hub` should avoid exposing `Fiber` in its APIs. ### Solution Remove the `takeFiber` and `putFiber` methods from both `Channel` and `Hub`. There's a performance cost in case a `Fiber` instance is needed but I think usability should be a priority.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fiberis a low-level effect with complex semantics for newcomers. Its functionality is essential for integrations and more low-level code butAsyncprovides better usability and covers a majority of use cases. For this reason,Fiber's API has become more limited over time and we don't even provide common combinators likeracefor it since the same functionality can be achieved viaAsynccombinators andAsync.runto obtain aFiber. I hadn't noticed thatfromCompletionStageis still inFiberand using an old method naming pattern with aFibersuffix.Solution
Move the method to
Asyncand removefromCompletionStageFiber.