8000 [core] remove putFiber/takeFiber from Channel and Hub by fwbrasil · Pull Request #1196 · getkyo/kyo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[core] remove putFiber/takeFiber from Channel and Hub #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[core] remove putFiber/takeFiber from Channel and Hub #1196

wants to merge 1 commit into from

Conversation

fwbrasil
Copy link
Collaborator
@fwbrasil fwbrasil commented May 17, 2025 •
edited
Loading

Problem

Following the rationale of #1195, Channel and Hub should avoid exposing Fiber in its APIs.

Solution

Remove the takeFiber and putFiber methods from both Channel and Hub. There's a performance cost in case a Fiber instance is needed but I think usability should be a priority.

@hearnadam
Copy link
Collaborator

Looks like README needs updating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hearnadam hearnadam hearnadam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fwbrasil @hearnadam
0