8000 refactor: Make INavigable extend IFocusableNode. by gonfunko · Pull Request #9033 · google/blockly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: Make INavigable extend IFocusableNode. #9033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 12, 2025
Merged

refactor: Make INavigable extend IFocusableNode. #9033

merged 3 commits into from
May 12, 2025

Conversation

gonfunko
Copy link
Contributor

The basics

The details

Resolves

Fixes #8943

Proposed Changes

This PR makes INavigable extend IFocusableNode, which is useful for converting between focused items and elements in the cursor traversal. It also moves isNavigable() onto INavigationPolicy instead of INavigable to allow it to be overridden/configured for classes (like BlockSvg, WorkspaceSvg and RenderedConnection) that are effectively not subclassable.

It may be possible to remove INavigable entirely pending the outcome of the discussion in #8992 (comment), but this change will be desirable in any case.

@gonfunko gonfunko requested a review from a team as a code owner May 12, 2025 22:28
@gonfunko gonfunko requested a review from BenHenning May 12, 2025 22:28
@gonfunko gonfunko force-pushed the focusable-navigable-merger branch from 318c88c to 6422d95 Compare May 12, 2025 22:28
@gonfunko gonfunko mentioned this pull request May 12, 2025
Merged
1 task
BenHenning
BenHenning approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor
@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gonfunko. Just one nit, otherwise LGTM!

@BenHenning BenHenning assigned gonfunko and unassigned BenHenning May 12, 2025
@BenHenning BenHenning mentioned this pull request May 12, 2025
Merged
1 task
@gonfunko gonfunko merged commit a1be83b into google:rc/v12.0.0 May 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenHenning BenHenning BenHenning approved these changes

Assignees

@gonfunko gonfunko

Labels
PR: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gonfunko @BenHenning
0