Installation: Use *Timestamp instead of *time.Time for the benefit of InstallationEvent #965
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://developer.github.com/v3/activity/events/types/#installationevent the
created_at
andupdated_at
timestamps in the event payloads are unix-formatted, while the CRUD APIs use RFC3339. Using*Timestamp
handles the unfortunate fact that the API is inconsistent. Without this change, my application emits the following errorI understand this might be a breaking change to the public API, so I'm open to feedback if there are alternative ways to proceed.
This change is