8000 github.App: Use *Timestamp instead of *time.Time by aidansteele · Pull Request #1179 · google/go-github · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

github.App: Use *Timestamp instead of *time.Time #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2019
Merged

github.App: Use *Timestamp instead of *time.Time #1179

merged 1 commit into from
Jun 11, 2019

Conversation

aidansteele
Copy link
Contributor

This is a similar issue to #965 - the created_at and updated_at fields in the app field of webhooks are formatted as Unix epoch integers, rather than RFC3339 for the CRUD APIs.

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label May 31, 2019
@codecov
Copy link
codecov bot commented May 31, 2019 •
edited
Loading

Codecov Report

Merging #1179 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1179   +/-   ##
=======================================
  Coverage   70.25%   70.25%           
=======================================
  Files          84       84           
  Lines        5867     5867           
=======================================
  Hits         4122     4122           
  Misses        956      956           
  Partials      789      789
Impacted Files Coverage Δ
github/apps.go 65.51% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8354c07...d77805f. Read the comment docs.

gmlewis
gmlewis approved these changes May 31, 2019
View reviewed changes
Copy link
Collaborator
@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. Thank you, @aidansteele!

LGTM.
Awaiting second LGTM before merging.

Note to self: This is a breaking API change and we will need to bump the release version after this gets in.

@gmlewis gmlewis requested a review from gauntface May 31, 2019 00:31
vaibhavsingh97
vaibhavsingh97 approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor
@vaibhavsingh97 8000 vaibhavsingh97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gmlewis
Copy link
Collaborator
gmlewis commented Jun 11, 2019

Thank you, @vaibhavsingh97!
Merging.

Note to self: this is a breaking API change so we will bump the major version after merging.

@gmlewis gmlewis merged commit d695b5b into google:master Jun 11, 2019
@gmlewis gmlewis mentioned this pull request Aug 19, 2019
Closed
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
@aidansteele @gmlewis
github.App: Use *Timestamp instead of *time.Time (google#1179)
125e05d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

@vaibhavsingh97 vaibhavsingh97 vaibhavsingh97 approved these changes

@gauntface gauntface Awaiting requested review from gauntface

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aidansteele @gmlewis @vaibhavsingh97 @googlebot
0