Remove GPUCommandEncoder.writeTimestamp #4370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previews, as seen when this build job started (c157439): |
Kangz
approved these changes
Nov 9, 2023
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Nov 9, 2023
This CL makes sure GPUCommandEncoder.writeTimestamp method requires enabling allow_unsafe_apis toggle as it has been removed from the spec while we get more experience before adding it back. Spec PR: gpuweb/gpuweb#4370 Bug: dawn:1800 Change-Id: Ibc886338876ee8a9877ff4ee8ff8e3bcb65afa0a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/159921 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Kokoro: Kokoro <noreply+kokoro@google.com>
kainino0x
approved these changes
Nov 9, 2023
7 tasks
ErichDonGubler
added a commit
to erichdongubler-mozilla/wgpu
that referenced
this pull request
Jan 30, 2024
See [`gpuweb/gpuweb`gfx-rs#4370](gpuweb/gpuweb#4370).
ErichDonGubler
added a commit
to erichdongubler-mozilla/wgpu
that referenced
this pull request
Jan 30, 2024
See [`gpuweb/gpuweb`gfx-rs#4370](gpuweb/gpuweb#4370).
ErichDonGubler
added a commit
to erichdongubler-mozilla/wgpu
that referenced
this pull request
Jan 30, 2024
See [`gpuweb/gpuweb`gfx-rs#4370](gpuweb/gpuweb#4370).
6 tasks
ErichDonGubler
added a commit
to erichdongubler-mozilla/wgpu
that referenced
this pull request
Feb 2, 2024
See [`gpuweb/gpuweb`gfx-rs#4370](gpuweb/gpuweb#4370).
ErichDonGubler
added a commit
to erichdongubler-mozilla/wgpu
that referenced
this pull request
Feb 8, 2024
See [`gpuweb/gpuweb`gfx-rs#4370](gpuweb/gpuweb#4370).
ErichDonGubler
added a commit
to erichdongubler-mozilla/wgpu
that referenced
this pull request
Feb 9, 2024
See [`gpuweb/gpuweb`gfx-rs#4370](gpuweb/gpuweb#4370).
ErichDonGubler
added a commit
to erichdongubler-mozilla/wgpu
that referenced
this pull request
Feb 21, 2024
See [`gpuweb/gpuweb`gfx-rs#4370](gpuweb/gpuweb#4370).
ErichDonGubler
added a commit
to erichdongubler-mozilla/wgpu
that referenced
this pull request
Feb 26, 2024
See [`gpuweb/gpuweb`gfx-rs#4370](gpuweb/gpuweb#4370).
ErichDonGubler
added a commit
to erichdongubler-mozilla/wgpu
that referenced
this pull request
Feb 26, 2024
See [`gpuweb/gpuweb`gfx-rs#4370](gpuweb/gpuweb#4370).
ErichDonGubler
added a commit
to erichdongubler-mozilla/wgpu
that referenced
this pull request
Mar 7, 2024
See [`gpuweb/gpuweb`gfx-rs#4370](gpuweb/gpuweb#4370).
juj
added a commit
to juj/wasm_webgpu
that referenced
this pull request
Mar 7, 2024
This was referenced Mar 18, 2024
ErichDonGubler
added a commit
to erichdongubler-mozilla/wgpu
that referenced
this pull request
Mar 28, 2024
See [`gpuweb/gpuweb`gfx-rs#4370](gpuweb/gpuweb#4370).
ErichDonGubler
added a commit
to erichdongubler-mozilla/wgpu
that referenced
this pull request
Apr 2, 2024
See [`gpuweb/gpuweb`gfx-rs#4370](gpuweb/gpuweb#4370).
ErichDonGubler
added a commit
to erichdongubler-mozilla/wgpu
that referenced
this pull request
Apr 18, 2024
See [`gpuweb/gpuweb`gfx-rs#4370](gpuweb/gpuweb#4370).
ErichDonGubler
added a commit
to erichdongubler-mozilla/wgpu
that referenced
this pull request
May 8, 2024
See [`gpuweb/gpuweb`gfx-rs#4370](gpuweb/gpuweb#4370).
ErichDonGubler
added a commit
to erichdongubler-mozilla/wgpu
that referenced
this pull request
May 30, 2024
See [`gpuweb/gpuweb`gfx-rs#4370](gpuweb/gpuweb#4370).
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in GPU Web 2023-11-08 meeting this PR removes
GPUCommandEncoder.writeTimestampfrom the spec.@kainino0x Please review.
cc #3952